Issue with parsing string as single type.

[colton-boi]

Skript/Server Version

[02:42:22 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[02:42:22 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[02:42:22 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[02:42:22 INFO]: [Skript] Server Version: git-Pufferfish-52 (MC: 1.19.3)
[02:42:22 INFO]: [Skript] Skript Version: 2.6.3
[02:42:22 INFO]: [Skript] Installed Skript Addons: 
[02:42:22 INFO]: [Skript]  - skript-gui v1.3-beta2 (https://github.com/APickledWalrus/skript-gui)
[02:42:22 INFO]: [Skript]  - DiSky v4.4.3
[02:42:22 INFO]: [Skript]  - skript-reflect v2.3 (https://github.com/TPGamesNL/skript-reflect)
[02:42:22 INFO]: [Skript]  - skRayFall v1.9.28 (https://sk.rayfall.net/)
[02:42:22 INFO]: [Skript]  - SkQuery v4.1.7
[02:42:22 INFO]: [Skript]  - SkriptJSON v1.0.0
[02:42:22 INFO]: [Skript]  - SkBee v2.5.1 (https://github.com/ShaneBeee/SkBee)
[02:42:22 INFO]: [Skript]  - FunkySk v1.0.2
[02:42:22 INFO]: [Skript]  - skript-holo v1.0.2 (https://github.com/Blueyescat/skript-holo)
[02:42:22 INFO]: [Skript] Installed dependencies: 
[02:42:22 INFO]: [Skript]  - Vault v1.7.3-b131

yes I know I have a lot of addons, shush

Bug Description

Setting a variable to string parsed as "test%string%" results in the error variable can only be set to one object, not more, while only a singular object is returned.

Expected Behavior

No error and the variable being set

Steps to Reproduce

All in the bug description. One way around this is to, instead of setting it to string parsed as "test%string%" setting it to second element of (string parsed as "%string%est%string%") but that shouldn't be necessary

You are also unable to set the variable to first element of string parsed as "test%string%"

Errors or Screenshots

No response

Other

No response

Agreement

• I have read the guidelines above and affirm I am following them with this report.

[TheLimeGlass]

This has always been intended behavior. Skript cannot grab the string value at parse time, only at runtime. This means Skript can't tell if you used single or multiple expression types in your string.

So in order to be able to support multiple expression types in the string %text% tier %number% the expression has to return false for isSingle indicating multiple values can be present when the custom text parse is used.

A solution could be making the parsed as custom text a literal String which we've been experimenting with in other things but this will remove the usage of variables and expressions etc in the text, or set it to a variable and use the soon to be implemented type hints of variables, but that's not something for awhile. Or maybe even seeing if it'll parse in the init method as I think it may work.

From documentation:

You have to save the expression's value in a list variable, e.g. set {parsed::*} to message parsed as "...".

The list variable will contain the parsed values from all %types% in the pattern in order. If a type was plural, e.g. %items%, the variable's value at the respective index will be a list variable, e.g. the values will be stored in {parsed::1::*}, not {parsed::1}.

[colton-boi]

If that's the case, just want to comment that running !set {d} to first element of (uncolored name of tool parsed as "text%string%") gives the following error https://pastebin.com/CD6p2iFR

[TheLimeGlass]

If that's the case, just want to comment that running !set {d} to first element of (uncolored name of tool parsed as "text%string%") gives the following error https://pastebin.com/CD6p2iFR

I cannot reproduce with a diamond sword named "testExample"

[TPGamesNL]

The pattern of ExprParse is already a literal, so analyzing the pattern to determine whether it will always be single during init is possible and won't break anything. It could also be analyzed to better specify the return type of ExprParse.

The ArrayStoreException will be fixed in #5274.