Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ReadOnlySpan<char> Improve performance after .netcoreapp2.1 #192

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Use ReadOnlySpan<char> Improve performance after .netcoreapp2.1 #192

merged 1 commit into from
Apr 15, 2019

Conversation

pengweiqhca
Copy link
Contributor

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues

Bug fix

  • Bug description.

  • How to fix?

New feature or improvement

netcoreapp2.0:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Parse 827.2 ns 16.38 ns 21.86 ns 0.1268 - - 536 B

netcoreapp2.1:

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
Parse 44.51 ns 0.8727 ns 1.252 ns - - - -

@liuhaoyang liuhaoyang added this to the 0.9.0 milestone Apr 11, 2019
@liuhaoyang liuhaoyang merged commit 9290417 into SkyAPM:master Apr 15, 2019
@pengweiqhca pengweiqhca deleted the span branch April 19, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhaoyang liuhaoyang liuhaoyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pengweiqhca @liuhaoyang