Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat SDK support list #1

Closed
15 tasks done
kaojohnny opened this issue Oct 4, 2016 · 1 comment
Closed
15 tasks done

Chat SDK support list #1

kaojohnny opened this issue Oct 4, 2016 · 1 comment

Comments

@kaojohnny
Copy link
Contributor

kaojohnny commented Oct 4, 2016

  • createConversation(participant_ids, admin_ids, title)
  • getOrCreateDirectConversation(user_id)
    createConversation(...) covered this case
  • getConversation(conversation_id)
  • getConversations()
  • updateConversation(conversation_id, title)
  • deleteConversation(conversation_id) backend plugin didn't support
  • addParticipants(conversation_id, participant_ids)
  • removeParticipants(conversation_id, participant_ids)
  • addAdmins(conversation_id, admin_ids)
  • removeAdmins(conversation_id, admin_ids)
  • createMessage(conversation_id, body, metadata, asset)
  • getMessages(conversation_id, limit, before_time)
  • getUnreadMessageCount(conversation_id)
  • markAsLastMessageRead(conversation_id, message_id)
  • subscribe(handler)
@kaojohnny
Copy link
Contributor Author

kaojohnny commented Oct 6, 2016

Some problems:

  1. There is no strict policy about conversation creation, looks like iOS and JS SDK does their own check when involving conversation creation. These checks based on following considerations:

    • Do we allow same groups of users to have multiple conversations?
    • is_direct_message attribute seems not useful? but need set by client SDK
    • is title required when creates a conversation?

    My suggestion is we should move conversation creation to python plugin's lambda function. No need to ask each SDK to write their own checks and then call save a conversation record.

  2. name field is missing in user table, so it's impossible to know the message sender name.

  3. What's the minimal number of members of a conversation?

  4. Chat SDK didn't support delete (conversation is referenced by user_conversation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants