Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Write Spec for General SSO login (with Facebook and Google Login as Reference) #350

Closed
tensiuyan opened this issue Apr 18, 2017 · 3 comments
Assignees

Comments

@tensiuyan
Copy link
Contributor

tensiuyan commented Apr 18, 2017

Write the spec at SkygearIO/features#5

@tensiuyan tensiuyan changed the title Support Facebook and Google+ login Support Facebook and Google login Apr 18, 2017
@chpapa chpapa changed the title Support Facebook and Google login Design General SSO login (with Facebook and Google Login as Reference) Apr 18, 2017
@cheungpat
Copy link
Contributor

@tensiuyan Currently auth provider is able to do this:

  • Login with auth provider.
  • Add another auth provider user to the current account. (e.g. “Add Facebook to your existing account”)

So basically if you login with a social account, a new account is created when the social account is not associated with anything. Therefore the auth provider function does not check the email address.

Do you mean that if a user have Facebook and Google both with abc@example.com email address, the skygear should notice this and do something different?

@tensiuyan
Copy link
Contributor Author

@cheungpat I think I kinda mixed up server level and API level items. I will clean it up after the product meeting 🙏

@chpapa chpapa changed the title Design General SSO login (with Facebook and Google Login as Reference) Write Spec for General SSO login (with Facebook and Google Login as Reference) Apr 18, 2017
@chpapa
Copy link
Contributor

chpapa commented Apr 24, 2017

@cheungpat I think Skygear should have ways to tackle the following situation: (as written on SkygearIO/features#5)

  1. Login by AuthProvider A, but the email already got another account from AuthProvider B, show an error and tell users to login with another AuthProvide B
  2. Login by AuthProvider A, but the email already got another account from AuthProvider B, tell users it is already merged.
  3. Login by AuthProvider A, but the email already got another account from AuthProvider B, assume it is two different accounts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants