-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XNATSlicer - Add extension #194
Comments
Hi Sunil, Thanks for contributing 👍 To add an extension to the index, it should be available for at least: Linux, MacOSX and Windows.
|
Sunil, how about you provide detailed instructions on the extension wiki page how it should be compiled/installed on Win64, before you figure out packaging issues on other platforms? |
Definitely. You'll see it on the wiki within the week. |
Hi JC, I'll thank you in advance here because I'm going to bug you a little bit :) I'm confused as to where to go next. The extension I'm trying to package is a scripted module. When you say "submit extension built against slicer nightly," can you explain this process further and also the necessity of it? My assumption here is that by pushing my .s4ext to the ExtensionsIndex I've given the Extension Manager all of the info it needs. I take it this is incorrect? Sunil |
By the way Jc: we (Dan Marcus and I) asked Sunil to go ahead with the -Steve On Mon, Feb 4, 2013 at 3:25 PM, sunilk-wustl notifications@github.comwrote:
|
@pieper: Sounds good. That side, as mention @fedorov, more details should Hi Sunil, I updated the documentation to clarify things. See Let me know if you still have questions. Hth On Mon, Feb 4, 2013 at 4:01 PM, Steve Pieper notifications@github.comwrote:
+1 919 869 8849 |
Hi JC, That did clarify things. Thanks. Just to review, here's what I understand needs to happen (please let me know where I'm wrong):
The question I have is are these steps needed for scripted modules? If so, why? (I can infer some reasons, but I just want to make sure...) Thanks again for letting me pester you here -- much appreciated. Sunil |
Hi Sunil, Steps are the same independently of the type of module bundled within an I consolidated the different FAQ pages of the wiki, would be great if you See There is also a FAQ link available from the developer page: Thanks On Mon, Feb 4, 2013 at 9:21 PM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
Hi JC, I've spent the last few days trying to accomplish this. I'm having issues with the following step: "Regenerate the .s4ext file by configuring your extension with CMake I can configure/generate/build OK with cmake-gui+VS2008, but no new *.s4ext files are created. There are other files that get created, just nothing with the ".s4ext" extension. My questions are as follows:
Thanks in advance, |
Hi Sunil, The line that trigger the generation of the extension description file is You should also see an output similar to the following one: [...] Configuring Scripted module: ScriptedLoadableExtensionTemplate [...] See [2] for an example. Hth [1] On Mon, Feb 11, 2013 at 3:22 PM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
Hi JC, I don't see a newly generated .s4ext file or a "Extension description has been written to:" line. Here's how my extension directory is organized: C:/Users/skumar01/Desktop/XNATSlicerWiki/ExtensionsIndex/Custom/ <-- custom .s4ext file Here's my cmake command-line output. As a side note, I previously used cmake-gui, but it appears to be no different: -sh-4.1$ cmake -DSlicer_DIR:PATH=C:/Users/skumar01/Desktop/Slicer-build/Slicer-build -DSlicer_EXTENSION_DESCRIPTION_DIR:PATH=C:/Users/skumar01/Desktop/XNATSlicerWiki/ExtensionsIndex/Custom -DCMAKE_BUILD_TYPE:STRING=Release C:/Users/skumar01/Desktop/slb/Slicer/Extensions/CMake |
For some reason, the description is not properly printed .. but looking at -- Extension:C:/Users/skumar01/Desktop/XNATSlicerWiki/ Hth On Mon, Feb 11, 2013 at 5:06 PM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
That's the original .s4ext file that I point cmake to, not the newly generated one. I'm guessing the new one should be in C:/Users/skumar01/Desktop/XNATSlicerWiki/ExtensionsIndex/Custom/bld, right? The timestamp on the file also confirms it hasn't been touched -- would cmake overwrite these files? |
Hi Sunil, There are two concepts:
of an extension each time it is configured. The output of the configuration
structure:
https://github.com/Slicer/ExtensionsIndex#build-your-own-set-of-extensions-against-slicer-trunk-build-tree
having to extensions: Foo and Bar
where s4ext will be implictly generated Let me know if you have any other questions. Also agree the documentation is confusion, will be working on it in the Thanks On Mon, Feb 11, 2013 at 5:29 PM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
Hi JC, What I'm saying is that I'm following process (1), but it doesn't look like it works. At least in Windows. For instance, I'm not getting any *.s4ext in the /path/to/Projects/Foo-build folder (for me, this is: C:/Users/skumar01/Desktop/XNATSlicerWiki/ExtensionsIndex/Custom/bld). Furthermore, the cmake output I posted above also shows that it doesn't create any new .s4ext file. (A VS2008 solution gets built fine, however.) Any ideas, or could this be a potential bug? -Sunil |
The log reported above is specific to process (2) since you were building an extension index. Anyway, as explained, if you look inside the folder:
After building the index, you should see that a description file has been "implicitly" generated. In this case, the generated description file should be the same has the one already existing in the folder For information, a template scripted extension is being build every night on VS2008. If you still have question, I propose you join tomorrow hangout 👍 |
Hi JC, I want thank you again for fielding my questions. It's greatly appreciated especially knowing how involved you are in all aspects of Slicer. I'm definitely interested in the hangout, though of all times I can't attend today's (assuming it's still at 4pm EST.) Going back to the thread, when you say: "After building the index, you should see that a description file has been "implicitly" generated. In this case, the generated description file should be the same has the one already existing in the folder..." do you mean there should be a new .s4ext file somewhere within the build path:
or is it the same XNATSlicer.s4ext file found in:
? Below is a list of the files in the build directory:
Notice there's nothing in the way of an .s4ext -- a file search verifies this. Again, everything builds OK.
Thanks again here, |
Hi Sunil, Given this new input, I am assuming you manually created the original s4ext include(${Slicer_EXTENSION_CPACK}) See here for an example: Hth On Tue, Feb 12, 2013 at 12:57 PM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
Hi JC, It looks like I'm getting a link error when I try and build the .sln file. (I've updated and built Slicer using the latest trunk, also.) I'm going to move this discussion to the dev mailing list in case others face the same issue. Thanks again for your help. Talk to you on the dev list! Sunil |
Sounds good. And make sure to point us to the source code. On Wed, Feb 13, 2013 at 11:31 AM, sunilk-wustl notifications@github.comwrote:
+1 919 869 8849 |
No link errors now. Dah! But still no regenerated .s4ext. Will move to dev list anyway. |
Closing the issue. A pull request will be submitted soon. |
Add XNATSlicer extension. See issue #194
Description: Secure File IO with any XNAT server. Win64 for now.
Wiki: http://www.slicer.org/slicerWiki/index.php/Documentation/4.2/Extensions/XNATSlicer
The text was updated successfully, but these errors were encountered: