-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SlicerIGSIO extension #1593
Conversation
I have no idea what IGISO is (and a quick google doesn't seem to help). Could you include a definition or link in the readme? |
492bdc5
to
7f6f583
Compare
Right. Added a link to the IGSIO repository and gave an example of some functionality (video IO). |
It's better, but I'd say you should have an explicit link this site, because it's the one that actually explains what is going on: http://igsio.github.io/ |
7f6f583
to
7e04107
Compare
This is our standard extension checklist:
This is a utility extension (not to be installed by end users, only to be installed by other extensions), so tutorials, etc. can refer to relevant end-user extensions. |
7e04107
to
3bd512a
Compare
@lassoan Ok, I think it should be more verbose and descriptive now. |
SlicerIGSIO.s4ext
Outdated
status | ||
|
||
# One line stating what the module does | ||
description This is a utility extension that is developed as part of is developed as part of the Image Guided Surgery InterOperability (IGSIO) organization (see http://igsio.github.io/), and should be used as a dependency for other extensions (Ex. SlicerIGT) to provide access to tools and algorithms implemented by IGSIO (https://github.com/IGSIO/IGSIO). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description This is a utility extension that is developed as part of is developed as part of the Image Guided Surgery InterOperability (IGSIO) organization (see http://igsio.github.io/), and should be used as a dependency for other extensions (Ex. SlicerIGT) to provide access to tools and algorithms implemented by IGSIO (https://github.com/IGSIO/IGSIO). | |
description This is a utility extension that is developed as part of the Image Guided Surgery InterOperability (IGSIO) organization (see http://igsio.github.io/), and should be used as a dependency for other extensions (Ex. SlicerIGT) to provide access to tools and algorithms implemented by IGSIO (https://github.com/IGSIO/IGSIO). |
Thank you, it looks good to me now - except the small type in the extension description. Please also update CMakeLists.txt file to be in sync with the s4ext file. |
3bd512a
to
bdcb321
Compare
@lassoan Done, thanks! |
Thank you! I'll merge this now. |
Relies on Slicer/Slicer#1028
@lassoan