Make config migration more robust #670
Conversation
Erimelowo
added
Type: Bug
server/src/main/java/dev/slimevr/config/CurrentVRConfigConverter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/dev/slimevr/config/CurrentVRConfigConverter.java
Outdated
Show resolved
Hide resolved
server/src/main/java/dev/slimevr/config/CurrentVRConfigConverter.java
Outdated
Show resolved
Hide resolved
| } catch (Exception e) { | ||
| LogManager.severe("Error during config migration: " + e); | ||
| } |
There was a problem hiding this comment.
If anything goes wrong, do we make a backup of the original config? We most definitely should. If it's not viable to do it on an error, then do it before any config migration is done.
There was a problem hiding this comment.
Not sure that’s possible with how it is currently set, but Uriel wants to rewrite the whole config system or something anyways…
There was a problem hiding this comment.
I think butter is saying to just copy the config file and put it into a .old one
There was a problem hiding this comment.
I know, but does the class have access to the file itself? All I see is that it has access to the content… not even the file path, and we can’t access vrServer because it’s in lateinit
There was a problem hiding this comment.
sigh, yeah lets leave it for the rewrite
There was a problem hiding this comment.
Unfortunate, probably "okay" then as long as it's fairly reliable
Please release 0.7.1 along with this