Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoseFrame fix & AutoBone change #736

Merged
merged 3 commits into from
Jun 19, 2023
Merged

PoseFrame fix & AutoBone change #736

merged 3 commits into from
Jun 19, 2023

Conversation

ButterscotchV
Copy link
Member

@ButterscotchV ButterscotchV commented Jun 19, 2023 •
edited

  • Fix ignoring computed trackers instead of internal trackers, HMD and controllers are now computed and they cannot be ignored
    • This caused issues with AutoBone recordings not including the HMD and giving terrible results
  • Added a config useSkeletonHeight (defaults to false) to choose to use the skeleton height if possible
    • Warning: This changes the default behaviour of AutoBone to use the recording's HMD height rather than the skeleton height

@ButterscotchV ButterscotchV self-assigned this Jun 19, 2023
@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: High Important feature or blocks something important Area: AutoBone The AutoBone feature Area: Server Related to the server labels Jun 19, 2023
@ButterscotchV ButterscotchV changed the title PoseFrame fix PoseFrame fix & AutoBone change Jun 19, 2023
@Eirenliel Eirenliel merged commit 652b44d into SlimeVR:main Jun 19, 2023
6 checks passed
@ButterscotchV ButterscotchV deleted the poseframe-fix branch June 20, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eirenliel Eirenliel Eirenliel approved these changes

@Erimelowo Erimelowo Erimelowo approved these changes

@loucass003 loucass003 Awaiting requested review from loucass003

Assignees

@ButterscotchV ButterscotchV

Labels
Area: AutoBone The AutoBone feature Area: Server Related to the server Priority: High Important feature or blocks something important Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ButterscotchV @Eirenliel @Erimelowo