Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tauri should work now #831

Merged
merged 3 commits into from
Aug 28, 2023
Merged

tauri should work now #831

merged 3 commits into from
Aug 28, 2023

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Aug 23, 2023

No description provided.

@ImUrX ImUrX added Type: Bug Something isn't working Priority: High Important feature or blocks something important Area: GUI Related to the GUI labels Aug 23, 2023
TheButlah
TheButlah approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@TheButlah TheButlah left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - but the fact that this is necessary reinforces my opinion that maybe upgrading to tauri 2 when its still in alpha is jumping the gun. But, /shrug

@ImUrX ImUrX marked this pull request as draft August 23, 2023 23:46
@ImUrX ImUrX marked this pull request as ready for review August 27, 2023 20:43
@ImUrX ImUrX requested a review from loucass003 as a code owner August 27, 2023 20:43
@Eirenliel Eirenliel merged commit 917092e into main Aug 28, 2023
10 checks passed
@Eirenliel Eirenliel deleted the fix-tauri-3 branch August 28, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eirenliel Eirenliel Eirenliel approved these changes

@TheButlah TheButlah TheButlah approved these changes

@Erimelowo Erimelowo Erimelowo approved these changes

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

Assignees
No one assigned
Labels
Area: GUI Related to the GUI Priority: High Important feature or blocks something important Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ImUrX @Eirenliel @TheButlah @Erimelowo