Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

griefPrevention and slimefun ( Claim#allowContainers ) #4117

Closed
4 tasks done
SrMonsterYT opened this issue Feb 3, 2024 · 4 comments
Closed
4 tasks done

griefPrevention and slimefun ( Claim#allowContainers ) #4117

SrMonsterYT opened this issue Feb 3, 2024 · 4 comments
Labels
🐞 Bug Report A bug that needs to be fixed. 🐌 Performance Problem This issue is related to performance issues, such as memory leaks or drops in timings.

Comments

@SrMonsterYT
Copy link

SrMonsterYT commented Feb 3, 2024 •
edited
Loading

❗ Checklist

  • I am using the official english version of Slimefun and did not modify the jar.
  • I am using an up to date "DEV" (not "RC") version of Slimefun.
  • I am aware that issues related to Slimefun addons need to be reported on their bug trackers and not here.
  • I searched for similar open issues and could not find an existing bug report on this.

📍 Description

slimefun is conflicting with griefPrevention, I reported it to griefPrevention and they pointed me to slimefun

image: https://prnt.sc/39yg_jPj5djv

📑 Reproduction Steps

have griefPrevention and slimefun, and it starts to lag the server

💡 Expected Behavior

no lag

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Purpur

🎮 Minecraft Version

1.20.x

⭐ Slimefun version

https://prnt.sc/PnU70Fb6nTaT

🧭 Other plugins

No response
@SrMonsterYT SrMonsterYT added 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. 🐞 Bug Report A bug that needs to be fixed. labels Feb 3, 2024
@J3fftw1
Copy link
Contributor

J3fftw1 commented Feb 11, 2024 •
edited
Loading

This is something they should handle.
We do not know their code thats why we leave it to them to update the dough protection module but since they gave clear instructions i will see if i can change this.

Edit: they apparently already made an PR:
Slimefun/dough#248

@J3fftw1 J3fftw1 added the 🐌 Performance Problem This issue is related to performance issues, such as memory leaks or drops in timings. label Feb 11, 2024
This was referenced Feb 11, 2024
Merged
Closed
@J3fftw1 J3fftw1 removed the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Feb 11, 2024
@SrMonsterYT
Copy link
Author

has this been resolved or does it need testing?

@J3fftw1
Copy link
Contributor

J3fftw1 commented Feb 16, 2024

This issue is still open so it’s not resolved

@J3fftw1 J3fftw1 mentioned this issue Mar 28, 2024
Merged
7 tasks
@J3fftw1
Copy link
Contributor

J3fftw1 commented Mar 28, 2024

Solved in #4165

@J3fftw1 J3fftw1 closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Report A bug that needs to be fixed. 🐌 Performance Problem This issue is related to performance issues, such as memory leaks or drops in timings.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@J3fftw1 @SrMonsterYT