Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error when fetch wasnt called because of RefreshTime? #38

Closed
Marschelloss opened this issue Oct 27, 2016 · 2 comments
Closed

Throw Error when fetch wasnt called because of RefreshTime? #38

Marschelloss opened this issue Oct 27, 2016 · 2 comments

Comments

@Marschelloss
Copy link

Hey there,

is it a good idea (or is it even possible without breaking the program because of error catching) to return an error when rss.Fetch() or feed.Update() failed because of the feed.Refresh time?

Its kinda confusing to receive a complete empty list after recalling the function without an error.

@SlyMarbo
Copy link
Owner

Yeah, that's a fair point. I'll add a relevant error, which will implement net.Error. In the meantime I'd recommend checking f.Refresh.After(time.Now()).

@Marschelloss
Copy link
Author

This is also a workaround i already found. But still: I was confused for quite some time, since i didn't receive an error nor a result i was expecting. This Issue will make the package not better. Just a little bit easier to use. So no high prio :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants