Skip to content

Commit

Permalink
Fix: correct an error I made in PR7160
Browse files Browse the repository at this point in the history
#### Brief overview of PR changes/additions
I made an error in Mudlet#7160 as I thought that something that looked like a
function call returned a value that could be assigned to something with a
`set(...)` but CMake doesn't work like that, instead one has to provide a
variable to recieve the value as the last argument to a `string(...)`
function. 🙄

#### Motivation for adding to Mudlet
Fix an error that causes cruft to appear, at least, in the version number
on the first tab of the "About Mudlet" dialogue.

#### Other info (issues closed, discussion etc)
This should close Mudlet#7220.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
  • Loading branch information
SlySven committed May 12, 2024
1 parent 6d7c931 commit baf583a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ execute_process(
# If a CI/CB build system provides an alternative Git SHA1 to identify the build
# use that instead - reporting which is being used:
if(DEFINED ENV{BUILD_COMMIT} AND NOT $ENV{BUILD_COMMIT} STREQUAL "")
set(GIT_SHA1 string(TOLOWER $ENV{BUILD_COMMIT}))
string(TOLOWER $ENV{BUILD_COMMIT} GIT_SHA1)
message(STATUS "Git SHA1 set from environemnt: ${GIT_SHA1}")
else()
message(STATUS "Git SHA1 used: ${GIT_SHA1}")
Expand Down

0 comments on commit baf583a

Please sign in to comment.