Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Networking #27

Closed
TBye101 opened this issue Jun 26, 2018 · 6 comments
Closed

Broken Networking #27

TBye101 opened this issue Jun 26, 2018 · 6 comments
Assignees

Comments

@TBye101
Copy link
Owner

TBye101 commented Jun 26, 2018

Networking no longer works in the master branch. (Should have tested that)
Protobuf-net cannot serialize the net structure.

@TBye101
Copy link
Owner Author

TBye101 commented Jun 30, 2018

Protobuf-net can now serialize my world structure, however on deserialize sometimes there is a stackoverflow exception.

@TBye101
Copy link
Owner Author

TBye101 commented Jul 1, 2018

One avenue of investigation is serialize and deserialize with the length prefix, to rule out if the messages are being merged.

@TBye101
Copy link
Owner Author

TBye101 commented Jul 1, 2018

Just verified that the issue only occurs when sending server ticks to the client.

@TBye101
Copy link
Owner Author

TBye101 commented Jul 1, 2018

The issue has something to do with deserializing a server tick message while deserializing the world.

@TBye101
Copy link
Owner Author

TBye101 commented Jul 1, 2018

I might have fixed the issue. As this bug is hard to reproduce, i'm just going to put it on the bug watchlist.

@TBye101
Copy link
Owner Author

TBye101 commented Jul 8, 2018

Fixed the issue with Marc Gravell's help. The real issue was TCP was being very selective when it sent messages and as such merged or only sent partial messages sometimes. This issue is fixed for now. However, more issues like this will occur until I handle partial messages in the future.

@TBye101 TBye101 closed this as completed Jul 8, 2018
TBye101 added a commit that referenced this issue Jul 8, 2018
This was referenced Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant