Skip to content
This repository has been archived by the owner on May 16, 2018. It is now read-only.

I will improve Scan QR function in later version #9

Closed
Sneezry opened this issue Apr 23, 2015 · 20 comments
Closed

I will improve Scan QR function in later version #9

Sneezry opened this issue Apr 23, 2015 · 20 comments

Comments

@Sneezry
Copy link
Owner

Sneezry commented Apr 23, 2015

jsqrcode works well at most of time, however, it fails in decoding sometimes. I will improve the lib in later version.

Maybe we need some computer vision knowledge.

@Sneezry
Copy link
Owner Author

Sneezry commented Apr 23, 2015

I have solved LazarSoft/jsqrcode#41, however, I still need more images to test. Please post any qr code we fail to decode.

@bkalar09
Copy link

bkalar09 commented May 1, 2015

I have several codes that AWS produces that can't be scanned.
image

@bkalar09
Copy link

bkalar09 commented May 1, 2015

Another that wont scan.
image

@Sneezry
Copy link
Owner Author

Sneezry commented May 1, 2015

Hi @bkalar09

Which version extension do you use? I can scan both of them with version 4.13


@bkalar09
Copy link

bkalar09 commented May 1, 2015

4.13

@Sneezry
Copy link
Owner Author

Sneezry commented May 1, 2015

Strange :-S

I have tested several times, and it works all the time~

@bkalar09
Copy link

bkalar09 commented May 1, 2015

I'm working on a screen shot of it in action

@Sneezry
Copy link
Owner Author

Sneezry commented May 1, 2015

I guess I know what the problem is... Is your display a retina one or do you zoom in or out your browser?

@bkalar09
Copy link

bkalar09 commented May 1, 2015

Here it is.
image

@bkalar09
Copy link

bkalar09 commented May 1, 2015

I am using a ThinkVision Pro 2840m. I don't zoom either.

@bkalar09
Copy link

bkalar09 commented May 1, 2015

My chrome version is Version "42.0.2311.135 m". The window I am using is "pinned" to the right side of the monitor. I am only using half of the screen for this instance of chrome.

@bkalar09
Copy link

bkalar09 commented May 1, 2015

My resolution is 3840 x 2160.

@Sneezry
Copy link
Owner Author

Sneezry commented May 1, 2015

OK, I think I know how to solve your issue, we fail to locate the qr code under some retina displays.

qr

I'm working on this now, please wait for a moment before I solve this :-)

Thanks for your feedback

@Sneezry
Copy link
Owner Author

Sneezry commented May 1, 2015

@bkalar09 version 4.14 now is available in web store, please update your extension and feedback further, thanks :-)

@multiwebinc
Copy link

@Sneezry For some reason it's not updating for me yet, however I am having the same problem with 4.13 if I scan twice. It works the first time but not the second time it doesn't scan correctly. It doesn't even draw the box on the screen when I drag the mouse.

@bkalar09
Copy link

bkalar09 commented May 1, 2015

That worked. Thanks

@multiwebinc
Copy link

It finally updated for me, but I still have the same problem.

@multiwebinc
Copy link

Here's a screencast of what I mean: http://youtu.be/qvz8_n16Qas

I don't know how to make the resolution higher on Youtube, sorry for the bad quality.

Here's the original file (2MB) in case you want it: http://www.filedropper.com/out-1

@Sneezry
Copy link
Owner Author

Sneezry commented May 2, 2015

@multiwebinc I watched the video, and I understand the problem you meet.

I think that is another issue about mouse event listening, I have created a new issue(#14) to track it.

@Sneezry
Copy link
Owner Author

Sneezry commented Nov 6, 2015

Scan QR works fine now.

@Sneezry Sneezry closed this as completed Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants