Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected CSS #24

Closed
James-Moon-Audio opened this issue Nov 9, 2017 · 6 comments
Closed

Expected CSS #24

James-Moon-Audio opened this issue Nov 9, 2017 · 6 comments

Comments

@James-Moon-Audio
Copy link

I've attempted to use the extension, but it does not display properly. I'm thinking it's due to the theme being used.

What CSS does this extension expect to have it display properly?

@Igloczek
Copy link
Contributor

Igloczek commented Nov 9, 2017

We are not shipping any CSS, b/c it's a tool for building custom menus, so at all, we expect that the CSS will be custom too. In the close future we are not going to change it, probably we will even remove more, like JS files, to just render a bunch of HTML code.

In the future we will release an open source theme which uses this module, so it will be styled and ready to use out of the box.

@Igloczek Igloczek closed this as completed Nov 9, 2017
@rav-redchamps
Copy link

@James-Moon-Audio If you are looking for support on Luma or Luma based themes then you may try this https://github.com/redchamps/snowdog-menu-luma-support we added Luma classes to the menu

@vseager
Copy link

vseager commented Feb 4, 2022

@Igloczek
Copy link
Contributor

Igloczek commented Feb 4, 2022

@vseager can you say a word or two about your module? Is that a fork of the previous one from RedChamps with some updates or something completely new?

@vseager
Copy link

vseager commented Feb 4, 2022

@Igloczek No, this module is completely new and built from scratch. Unlike the RedChamps module which tried to replicate the template and classes of Luma, my module doesn't attempt to replicate any core templates and uses all core logic.

The only difference between my module and core Magento is that the core builds the menu nodes from the category structure. I am instead I am pulling out nodes from the SnowDog menu, and building the menu that way. This is all backend logic before it hits the frontend. As a result, my module works flawlessly with Luma and the Magento core, and should Magento update Luma templates/CSS/JS, then it won't have any negative effect, as this module doesn't have any frontend involvement at all.

@Igloczek
Copy link
Contributor

Igloczek commented Feb 4, 2022

Nice! I'll put your module on the list in the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants