Bringing back AuthenticationAdapterChainFactory #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing provider authentication set a custom auth adapter in the ZfcUser Controller Plugin. The factory creates a new instance of the AdapterChain with only the HybridAuth adapter. It also makes sure to reset ZfcUser module options.
|
Tested and working! #125 For these who uses ScnSocialAuth-doctrine-orm module also, the composer should be set as "socalnick/scn-social-auth": "dev-hotfix/dedicated-auth-adapter-chain as 1.11.3", (must be tagged) |
|
@matwright - could you give this a try? |
|
This looks like a good solution. I've been meaning to test it. I should get chance a little later this week and will feedback. |
|
Tested and working ! |
SocalNick
added a commit
that referenced
this pull request
Jan 14, 2014
…chain Bringing back AuthenticationAdapterChainFactory
This was referenced Jan 14, 2014
gsomoza
pushed a commit
to gsomoza/ScnSocialAuth
that referenced
this pull request
Mar 2, 2015
Steam provider tuning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know everyone is waiting for #125 to be merged, but I would like to propose an alternative implementation. This creates an AdapterChain just for ScnSocialAuth instead of trying to hijack the one in ZfcUser.
When doing provider authentication set a custom auth adapter in the ZfcUser Controller Plugin. The factory creates a new instance of the AdapterChain with only the HybridAuth adapter. It also makes sure to reset ZfcUser module options.
bjyoungblood/BjyAuthorize#208
#123
#127