collectCycles() is being called many times in a single transaction (Performance issue)

[clinuxrulz]

I think in Transaction.ts:

        if (this.collectCyclesAtEnd) {
            Vertex.collectCycles();
            this.collectCyclesAtEnd = false;
        }

needs to change to:

        if (this.collectCyclesAtEnd && Transaction.currentTransaction == null) {
            Vertex.collectCycles();
            this.collectCyclesAtEnd = false;
        }

I tried out a hook to see how often collectCycles was called in 1 transaction via:

sodium.Vertex.collectCycles = (function() {
    let realCollectCycles = sodium.Vertex.collectCycles;
    return function() {
        console.log("collectCycles start");
        realCollectCycles();
        console.log("collectCycles end");
    };
})();

And it was called way too many times.

I've got a temporary work-around hook though, so it is not causing me grief at the moment:

sodium.Vertex.collectCycles = (function() {
    let realCollectCycles = sodium.Vertex.collectCycles;
    let collectingCycles = false;
    return function() {
        if (collectingCycles) {
            return;
        }
        collectingCycles = true;
        window.setTimeout(() => {
            console.log("collectCycles start");
            realCollectCycles();
            console.log("collectCycles end");
            collectingCycles = false;
        });
    };
})();

[clinuxrulz]

this.collectCyclesAtEnd && Transaction.currentTransaction == null did not seem to do the trick for me. Will need to think about this one some more.

[clinuxrulz]

Could this be from Transaction.post which is updating cell values before the next transactions? Like the updating of cells causing many intermediate transactions re-triggering collectCycles() over and over again. We might just need a better location to call collectCycles().

When I was profiling some slow code at work, collectCycles()'s total time was 80% compared to other total times. The "temporary work-around hook" I've listed above made the problem completely go away, but it can only be used if your using sodiumjs for the browser. If your using sodiumjs for node.js or some other target, then we probably wont have window.setTimeout() available.