Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang Static Analyzer: add support for full path/flow to a given issue #1707

Closed
romanek-adam opened this issue Apr 16, 2019 · 4 comments · Fixed by #1710
Closed

Clang Static Analyzer: add support for full path/flow to a given issue #1707

romanek-adam opened this issue Apr 16, 2019 · 4 comments · Fixed by #1710
Assignees
Milestone

Comments

@romanek-adam
Copy link
Contributor

The goal of this task is to extend Clang Static Analyzer support in sonar-cxx plugin with the full path to a given issue (which can be found under the "path" key in CSA's *.plist files; it's also called "flow" in SQ terms).

@romanek-adam
Copy link
Contributor Author

I have a working solution on my desk which I'm about to upload shortly.

@guwirth
Copy link
Collaborator

guwirth commented Apr 16, 2019

Hi @romanek-adam,

we are interested to see you solution.

Regards,

@romanek-adam
Copy link
Contributor Author

Hi @guwirth ,
Have you seen my PR? Please see my comment in it.

@guwirth
Copy link
Collaborator

guwirth commented Apr 19, 2019

@romanek-adam yes, see comments there.

@guwirth guwirth added this to the 1.3.0 milestone Apr 19, 2019
romanek-adam pushed a commit to LibertyGlobal/sonar-cxx that referenced this issue Apr 19, 2019
romanek-adam pushed a commit to LibertyGlobal/sonar-cxx that referenced this issue Apr 23, 2019
romanek-adam pushed a commit to LibertyGlobal/sonar-cxx that referenced this issue Apr 24, 2019
ClangStaticAnalyzer is good at finding issues which involve a certain
path in code, with given constraints and values of particular variables.
Its HTML reports visualize the full path from the start to the final
location, showing all the intermediate steps and the assumptions taken.
The path and conditions are very often critical to understand why CSA
reports a given issue. Without them one can easily judge CSA for
reporting a false positive, while in fact the issue is there, but the
conditions are non-obvious.

Currently sonar-cxx only reports the final location of a given issue.
This PR addresses this shortcoming and closes the gap to CSA's HTML
reports. With this PR SonarQube is now able to present the full path to
a given issue, which provides similar UX to CSA's HTML reports.

Closes SonarOpenCommunity#1707.
romanek-adam pushed a commit to LibertyGlobal/sonar-cxx that referenced this issue Apr 25, 2019
ClangStaticAnalyzer is good at finding issues which involve a certain
path in code, with given constraints and values of particular variables.
Its HTML reports visualize the full path from the start to the final
location, showing all the intermediate steps and the assumptions taken.
The path and conditions are very often critical to understand why CSA
reports a given issue. Without them one can easily judge CSA for
reporting a false positive, while in fact the issue is there, but the
conditions are non-obvious.

Currently sonar-cxx only reports the final location of a given issue.
This PR addresses this shortcoming and closes the gap to CSA's HTML
reports. With this PR SonarQube is now able to present the full path to
a given issue, which provides similar UX to CSA's HTML reports.

Closes SonarOpenCommunity#1707.
haghighi pushed a commit to haghighi/sonar-cxx that referenced this issue Jun 22, 2019
ClangStaticAnalyzer is good at finding issues which involve a certain
path in code, with given constraints and values of particular variables.
Its HTML reports visualize the full path from the start to the final
location, showing all the intermediate steps and the assumptions taken.
The path and conditions are very often critical to understand why CSA
reports a given issue. Without them one can easily judge CSA for
reporting a false positive, while in fact the issue is there, but the
conditions are non-obvious.

Currently sonar-cxx only reports the final location of a given issue.
This PR addresses this shortcoming and closes the gap to CSA's HTML
reports. With this PR SonarQube is now able to present the full path to
a given issue, which provides similar UX to CSA's HTML reports.

Closes SonarOpenCommunity#1707.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants