Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase file paths in Xunit reports are changed to lowercase on case sensitive operating systems #2303

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

jnicol31
Copy link

@jnicol31 jnicol31 commented Jan 25, 2022

Hello,

This pull-request should hopefully close #2302.

Comments are welcome !

Regards.


This change is Reviewable

Julien NICOL added 2 commits January 25, 2022 10:38
Using system dependent file paths for XUnit reports test case filenames should logically prevent duplications and allows successfull location on every file systems
@guwirth guwirth added the bug label Jan 25, 2022
@jnicol31 jnicol31 marked this pull request as ready for review January 25, 2022 10:12
@guwirth
Copy link
Collaborator

guwirth commented Jan 25, 2022

@jnicol31 thx looks good.

Only case I have to think about it's case where no filename exists and test is assigned to TestFile 'global', if behaviour is still the same? Not sure if there is a test for 'global'?

@guwirth guwirth added this to the 2.0.7 milestone Jan 25, 2022
@jnicol31
Copy link
Author

jnicol31 commented Jan 25, 2022

@guwirth When no filename exists, the TestFile was and is still constructed with a null parameter. Is it what you call 'global' ? If it is, this case is covered by the unit tests and I did not change the existing behaviour.

@guwirth
Copy link
Collaborator

guwirth commented Jan 25, 2022

@jnicol31 thx yes that is the case I mean. That is the open point I like to verify. Rest looks good!

@guwirth guwirth self-requested a review January 25, 2022 22:30
Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnicol31 verified, looks good. Thanks a lot for your contribution!

@guwirth guwirth merged commit 7ab56af into SonarOpenCommunity:master Jan 25, 2022
@jnicol31
Copy link
Author

@guwirth You're welcome. Thanks a lot for your support and your responsiveness !

@guwirth guwirth changed the title Close 2302 Uppercase file paths in Xunit reports are changed to lowercase on case sensitive operating systems Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Uppercase file paths in Xunit reports are changed to lowercase on case sensitive operating systems
2 participants