New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick fix for S3696 ('no-throw-literal') #3050

Merged

vilchik-elena merged 2 commits into master from issue-3017

Mar 17, 2022

Contributor

yassin-kammoun-sonarsource commented Mar 16, 2022

Fixes #3017


          Add quick fix for S3696 ('no-throw-literal')

aba52ff

yassin-kammoun-sonarsource force-pushed the issue-3017 branch from 525e634 to aba52ff Compare

March 16, 2022 15:01

vilchik-elena approved these changes

View reviewed changes

eslint-bridge/src/rules/decorators/no-throw-literal-decorator.ts

+                      const thrownText = context.getSourceCode().getText(thrown);
+                      suggest.push({
+                        desc: 'Throw an error object',
+                        fix: fixer => fixer.replaceText(thrown, `new Error(${thrownText})`),

Contributor

vilchik-elena Mar 17, 2022

I wonder if it's more reliable to use insertTextAfter and insertTextBefore instead of context.getSourceCode().getText(). WDYT?

Contributor Author

yassin-kammoun-sonarsource Mar 17, 2022

Hard to say... I propose we keep it like this for now. If we manage to break the fix during validation, depending on the problem, we can then try those methods.


          Merge branch 'master' of https://github.com/SonarSource/SonarJS into …

8c02447

…issue-3017

sonarsource-next bot commented Mar 17, 2022

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

vilchik-elena merged commit 9b43dfb into master

vilchik-elena deleted the issue-3017 branch

March 17, 2022 10:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment