Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move css rule to a separate folder #4201

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Move css rule to a separate folder #4201

merged 5 commits into from
Sep 28, 2023

Conversation

alex-sonar
Copy link
Contributor

Remaining item for 'each rule in a separate folder' topic

@alex-sonar alex-sonar marked this pull request as ready for review September 26, 2023 12:58
ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed, check with a local SQ instance that the scope changes do not miss files.

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alex-sonar alex-sonar merged commit 3107ed5 into master Sep 28, 2023
13 checks passed
@alex-sonar alex-sonar deleted the techdir-rule-folder-css branch September 28, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees

@alex-sonar alex-sonar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-sonar @ilia-kebets-sonarsource