Fix FP S3800 (function-return-type): Exception for sanitation functions
#4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand-sonarsource
force-pushed
the
issue-4527
branch
2 times, most recently
from
32a4a88
to
87df62a
Compare
ericmorand-sonarsource
force-pushed
the
issue-4527
branch
from
87df62a
to
dfd4587
Compare
|
ericmorand-sonarsource
requested review from
ilia-kebets-sonarsource and
yassin-kammoun-sonarsource
| @@ -1,37 +1,5 @@ | |||
| { | |||
| "vuetify:packages/docs/src/examples/v-date-picker/event-events.vue": [ | |||
| 44 | |||
| ], | |||
There was a problem hiding this comment.
For information, I checked all the removed lines and can confirm that they are not triggering the rule anymore - they all belong to a sanitation function.
| @@ -468,13 +491,6 @@ ruleTesterTs.run(`Functions should always return the same type [ts]`, rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This test was moved from the invalid list to the valid one.
| @@ -533,6 +549,14 @@ ruleTesterTs.run(`Functions should always return the same type [ts]`, rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| code: ` | |||
There was a problem hiding this comment.
I added this test to guarantee that only functions with true and string return types are valid.
yassin-kammoun-sonarsource
approved these changes
Feb 5, 2024
| @@ -1,37 +1,5 @@ | |||
| { | |||
| "vuetify:packages/docs/src/examples/v-date-picker/event-events.vue": [ | |||
| 44 | |||
| ], | |||
| @@ -468,13 +491,6 @@ ruleTesterTs.run(`Functions should always return the same type [ts]`, rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| @@ -533,6 +549,14 @@ ruleTesterTs.run(`Functions should always return the same type [ts]`, rule, { | |||
| }, | |||
| ], | |||
| }, | |||
| { | |||
| code: ` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4527