Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6958: No literal call #4621

Closed
wants to merge 1 commit into from
Closed

Create rule S6958: No literal call #4621

wants to merge 1 commit into from

Conversation

ericmorand-sonarsource
Copy link
Contributor

Fixes #4509

zglicz
zglicz reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool! It's my first time seeing a new rule getting added.
Will leave to other folks to Approve/Request changes, if there is something else to add or missing.

packages/jsts/src/rules/S6958/unit.test.ts Show resolved Hide resolved
packages/jsts/src/rules/S6958/unit.test.ts Show resolved Hide resolved
packages/jsts/src/rules/S6958/rule.ts Show resolved Hide resolved
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title [DRAFT] Create rule SXXX: No literal call Create rule S6958: No literal call Mar 27, 2024
@ilia-kebets-sonarsource ilia-kebets-sonarsource mentioned this pull request Mar 27, 2024
Merged
@ilia-kebets-sonarsource
Copy link
Contributor

closing and continuing in #4638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz left review comments

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule S6958: No literal call
3 participants
@ericmorand-sonarsource @ilia-kebets-sonarsource @zglicz