Resolve issue #4459: Fix FP S2699 (Tests should include assertions): global expect() aren't detected
#4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand-sonarsource
force-pushed
the
issue-4459
branch
from
a3ab425
to
ee5b064
Compare
|
vdiez
approved these changes
Mar 26, 2024
zglicz
reviewed
Mar 27, 2024
| @@ -19,6 +19,10 @@ describe('vitest test cases', () => { | |||
| check(); | |||
| }); | |||
|
|
|||
| it('recognizes global expect as an assertion', () => { | |||
There was a problem hiding this comment.
qq: this test is exactly the same as the one in lines 10-12. Whats the change here? Why is it marked as compliant when it seems it should only become compliant after your update?
There was a problem hiding this comment.
That's a very good point. The test I added does not prove anything since expect is imported in this file and my test intended to prove that expect was recognized as an assertion even when it is not imported.
I'll add a dedicated test. Thanks for noticing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4459