don't raise for reference types in nullable context

SonarSource · May 22, 2024 · 4e24132 · 4e24132
1 parent 9423b57
commit 4e24132
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 22 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
@@ -103,7 +103,7 @@ private static bool CanBeUsedInModelBinding(INamedTypeSymbol type) =>
 
     private static bool CanBeNull(ITypeSymbol type) =>
         type is ITypeParameterSymbol { HasValueTypeConstraint: false }
-        || (type.IsReferenceType && type.NullableAnnotation() != NullableAnnotation.NotAnnotated)
+        || type.IsReferenceType
         || type.IsNullableValueType();
 
     private static void GetAllDeclaredProperties(ITypeSymbol type, ConcurrentDictionary<ITypeSymbol, bool> examinedTypes, List<IPropertySymbol> declaredProperties)

diff --git a/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp8.cs b/analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/AvoidUnderPosting.CSharp8.cs
@@ -10,10 +10,15 @@ public class ModelUsedInController
         // Otherwise, strings behave always as nullable reference types.
 #nullable enable
         public string NonNullableReferenceProperty { get; set; }
+        public object AnotherNonNullableReferenceProperty { get; set; }
         [Required] public string RequiredNonNullableReferenceProperty { get; set; }
         public string? NullableReferenceProperty { get; set; }
+        public int ValueProperty { get; set; }                // Noncompliant
+        public int? NullableValueProperty { get; set; }
 #nullable disable
         public string ReferenceProperty { get; set; }
+        public object AnotherReferenceProperty { get; set; }
+        public int? AnotherNullableValueProperty { get; set; }
     }
 
     public class DerivedFromController : Controller
@@ -25,24 +30,3 @@ public IActionResult Create(ModelUsedInController model)
         }
     }
 }
-
-namespace CustomGenerics
-{
-    public class GenericType<TNoContstraint, TClass, TStruct, TNotNull>
-        where TClass : class
-        where TStruct : struct
-        where TNotNull : notnull
-    {
-        public TNoContstraint NoConstraintProperty { get; set; }
-        public TClass ClassProperty { get; set; }
-        public TStruct StructProperty { get; set; }                             // Noncompliant
-        [Required] public TStruct RequiredStructProperty { get; set; }
-        public TStruct? NullableStructProperty { get; set; }
-        public TNotNull NotNullProperty { get; set; }                           // Noncompliant
-    }
-
-    public class ControllerClass : Controller
-    {
-        [HttpPost] public IActionResult Create(GenericType<object, string, int, DateTime> model) => View(model);
-    }
-}