-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle Downloading #300
Comments
Comment from haob on Trello: This feature is really important for all non-English speaking.. ! |
Comment from manusfreedom on Trello: If you can add at minimum the possibility to call a program/script. |
Comment from evtk on Trello: I'm curious why this hasn't been listed as a higher priority. This is, for all the non-english speaking, a very imported feature! Would be nice if I don't have to use Autosub anymore.. or the build in feature from SB. Please look into this. thanks! |
Comment from markus101 on Trello: @evtk We needed to find a solution for managing files, such as metadata, subtitles and other extra files so they can properly be handled during renames. Looking at it now, there aren't many details on here, preliminary questions: What site is best? Opensubtitle's API is pretty bad, I spent a few minutes looking at it and I'm not even sure if it supports searching for episodes. Subtitle Seeker looks nice, has more subtitles available (assuming the stats on the two sites are correct) and an API I could work with. Is there something else? What language? English? User's choice? Most look to be in English, but I'm not sure if that helps (unless its just easier to understand when reading instead of listening). When do subs become available? When should drone look for them? Should drone search for subtitles from previous episodes? or just newly downloaded ones? Should it be per show or global to enable downloading? |
Comment from ctlaltdefeat on Trello: Unfortunately I don't have much input regarding implementation, but would just like to confirm that reading is much easier than listening, and that I would personally like to see this higher priority. |
Comment from evtk on Trello: @markus101 good you're letting know, that you are missing the details here. Let me get some input for you:
Hope this is some useful input to get this going! One last suggestion: you maybe want to get in contact with the developer of AutoSub. In this program there is a lot of experience build up with subtitle searching. Would be a waste if you would be doing it all over again. Maybe things can get integrated? |
Comment from phunkysai on Trello: I would like to add my +1 for this feature....would be great to have this integrated, since I grab a lot of English subs for my wife who is hearing impaired... |
Comment from evtk on Trello: @markus101 can you give me a status update? Any work on this request? Oh: i also would like to add to below feature list, that NzbDrone should be able to delete no longer needed subtitles (e.g. when a better quality of another release group is found and downloaded. Now the subtitles stay on disk, while they should be deleted, since they do not correspond with the new downloaded release). |
Comment from dr_dre on Trello: this would def be a +1 option for me aswell. seing that sickbeard-tpb has this aswell It would be a huge plus 1 :) |
Comment from fubduck on Trello: There is a post processing script usable with nzbget that downloads the subtitle file. I don't use it currently because nzbdrone ignores the file and deletes it along with the folder when renaming from the dronefactory folder. Would it be possible to use this type of script to get the subtitle in nzbdrone? Or is it easier to just have nzbdrone just move the already downloaded file? |
Comment from travisreimer on Trello: Plex can be set to get them automatically too, but i still upvote, lol. |
Comment from carbon007 on Trello: Some Ideas:
Thanks :) |
Comment from martinblom1 on Trello: This would be a very nice feature, also having it integrated means we can grab the subtitles before a rename (better chance of finding the correct sub). |
Comment from mbnn on Trello: It would be awesome to have thuis built in yes, but pls make sure we can also save with language extension like .en.srt and .nl.srt :) |
Comment from arnauddartois on Trello: why not use opensubtitle ? the api use a hash for the file, si you get the perfect subtitle. i use it with filebot for french sub, it's working perfectly. |
Comment from kubra9 on Trello: Instead of downloading subtitles, I would be very happy with an option to move and rename downloaded subtitle together with the series file. SB has this option. I use AutoSub Bootstrap Bill for downloading subtitles. |
Comment from cliff66 on Trello: It doesn't have to be a download feature. The option to keep *.srt (and others) files and also rename / move them would be a great first step, because often there are subtitles included in the release. |
Comment from markus101 on Trello: @cliff66 @kubra9 thats a separate card: https://trello.com/c/IzNiSitU/230-move-additional-files |
Comment from evtk on Trello: So it's been a while. I'm curious to know why this still is in low priority. For the non-native English people, having subs in your own language remains a must for some series (e.g. The Newsroom, damn they are going fast). I would love to have this card make a move to some higher priority. I'm sorry I can't help out more, other then what I already added in this card @ Mar 23, 2014 at 1:01 pm. Any thoughts? Thanks! |
Comment from stevebennett12 on Trello: @evtk I imagine it is a lower priority as plex and kodi can both already do these features on the fly :) But it would be a nice feature, possibly add opensubtitles.org? |
Comment from jeroenpraat1 on Trello: Why is this low priority? Should be at least medium priority. This is not only important for non-English speakers, but also for English speakers that want to follow foreign series. The most important reason however to make this a higher priority is because of accessibility for the deaf and hard of hearing. Maybe Subliminal can be a start: https://github.com/Diaoul/subliminal |
Comment from daveberkenkamp on Trello: Another person hoping that you will implement subtitle downloading. Especially that because after processing/renaming it will be difficult to get the right version for the right release. Adding Opensubtitles to this feature would be a good idea as well. With the number of votes currently going for it, I would also think the priority could be a bit higher. ;) |
Comment from trash71 on Trello: just curious but what's the use of trying to download the subs when the episode is just released, |
Comment from jeroenpraat1 on Trello: @trash71 Many times subtitles become available in 1 or 2 days. I think Sonarr just needs an interval to check for subtitles. Example: in 6, 12 and 24 hours, 2 days, 4 days. After that, people can check it manually. |
Comment from mbnn on Trello: If you do implement this (which would rock!) then please allow subs to be saved with country extension like: name.nl.srt and name.en.srt so Plex will know what language a srt file is :) |
Comment from daveberkenkamp on Trello: @trash71 Still, there could be like a "completing" feature. Sonarr knows which release it got succesfully, so it also knows which sub should go with it. It doesn't have to be available right away (like you say, the episode needs to be subbed first after release so there will be no concurrent release of the episode and the sub) but just a checking progress, an option that you would like subs with your shows, and then Sonarr can keep progress, just like it does with the episodes. :) |
Comment from youphulsebos1 on Trello: I would love this feature and have started setting up a dev machine in Azure to work on it. How can I move this card to In Progress? |
Comment from gizmo13 on Trello: I agree with @jeroenpraat1 Subliminal can be a start: https://github.com/Diaoul/subliminal. CouchpotatoServer https://github.com/RuudBurger/CouchPotatoServer uses Subliminal too for downloading the subs. |
Comment from blackbird11 on Trello: For me, its the only thing missing on this wonderful app. |
Comment from wagolouage on Trello: This feature would get me switching from SickRage to Sonarr. Programs like subliminal and Autosub are to hard to setup for me. |
@trinket it could be a possibility, I don't have too much experience working with C# (Sonarr is developed in that language) but I could give a try somewhen. |
@silk186 the script assumes that no srt subtitle is in the directory, we could add that validation and skip the search in that case, could you please fill an issue? |
Hi @evtk, yes, that would be enough, after install it just try to run this command: |
Hi, I get a: "-sh: subliminal: command not found". I guess the console is not registered within the syno box after installing subliminal? |
Is it possible to use nzb name when searching for subs, either via sonarr or nzbget script? The nzb names before renaming will often have matching scene release subs. |
@evtk Hi, I think that you will need to double check if:
I'm not a Synology user but if I assume that you have bash as shell interpreter you can override the export PATH="<path-to-subliminal-binary>${PATH}" |
@oppsig I'm not sure if subliminal supports that, it it's supported, I can add it as a feature. Thanks |
@ebergama seems your solution is good, but i dont know how install subliminal on my windows, can you help me? |
I created a post-processing script to automatically search subtitles by hash. |
Hi, sometimes, Sonarr download shows from teams where there is no subtitles available. It would be nice than Sonarr check before downloading a release if a subtitle exists. |
If anyone here cares, I made a lazy edit of the script to allow it to run with sonarr and subliminal in a docker container, here. The initial script run by sonarr doesn't actually search, but only adds the file to the wanted list, because you can't run a docker container from inside a docker container. The crontab search wanted script takes care of the actual downloading. |
@driminicus How do I run the install script if i'm running Sonarr in a docker under unRAID? Would the script also work in radarr? |
You run the install script outside of docker, on the host machine. All the install script does is add a crontab entry to regularly run the search-wanted.sh, which in turn will read the subs.wanted file and spin up a docker version of subliminal, search for the wanted subtitles, and remove the subliminal docker container. It's important that the user that adds the crontab entry (ie runs the install script) is allowed to run docker commands. Just to be clear: the sub-downloader.sh runs inside the docker container, writes to the subs.wanted file that is supposed to go in a docker volume, which is then accessed from outside the container, to run the searches using search-wanted.sh I haven't tried it under radarr, but assuming subliminal works for movies and the way radarr runs external scripts is the same, I see no reason why it wouldn't work. I'm fairly sure you can even run a single instance of the search-wanted.sh script in crontab and just add both movies and series to the subs.wanted file from inside the docker container. I hope that helps. Oh, as an afterthought, you don't really have to run the search-wanted.sh that uses the dockerized version of subliminal, you could install subliminal on the host machine and run the 'normal' search-wanted version. You would have to fiddle around with the volumes and paths of the location of your movies/series. edit: I should probably mention @jrdnlc |
I've noticed on tv shows that have non-english speaking scenes the original subtitles for those scenes are not included. Is this expected behaviour for Sonarr as subtitles, in general, are not currently a supported feature? |
i would like to know if it is possible to add another website to the list http://www.subhd.com - this is for HK & Chinese Mainland subtitles they also are on Kodi as well through the Superrepo . and they are also well organised. |
No that's not possible. Filebot strictly works with opensubtitles.org
Op ma 24 jul. 2017 04:19 schreef rp4k <notifications@github.com>:
… i would like to know if it is possible to add another website to the list
http://www.subhd.com - this is for HK & Chinese Mainland subtitles they
also are on Kodi as well through the Superrepo . and they are also well
organised.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#300 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD4VlWmBta9QhJpsjvEihh0NUel8D2eFks5sQ_8ygaJpZM4FmBBW>
.
|
I just wanted to add that it occurs quite often that Sonarr downloads a episode from some "unpopular" release group, resulting in very hard to find subtitles, quite often impossible to find. This then results in obtaining out of sync subtitles and manually adjusting the sync during playback every 10 minutes. How can we force Sonarr to download releases from "popular"release groups? Or perhaps Sonarr should be able to check first if a release from a certain release group has subtitles available. |
I see a lot of solutions that propose running a post-processing script on download of the show, which in principle works fine. However, the issue that I run into consistently is that subtitles are not available on the download of a show, and I see no way to re-execute the script for a show already post-processed and filed. For this reason I see it better being a feature built into Sonarr. |
@stevietv my small tool supports that with some small configurations explained in the |
@stevietv my tool also solves that problem: https://github.com/Inrego/addic2subs |
Hey guys, been working on a tool for some time. You can take a look at it: https://github.com/morpheus65535/bazarr Your comment are welcome! |
Hello, I want to create an integration to sonarr. Can somebody help me to get started? Not sure where to look for documentation and other stuff. Thanks |
The wiki is a good start: You can also take a look at Bazarr source code and it should help you a lot. Good luck! :-) |
@morpheus65535 I will take a look. Thank you |
Closing; No Appetite for this; Bazaar Exists |
Look at possibility of having the option of being able to grab subtitles from opensubtitles if option set to on for a particular series.
http://www.subtitleseeker.com/
Option to choose how often to look for subtitles 1, 2, 4 hours
Providers
The text was updated successfully, but these errors were encountered: