Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lets add warning log msgs when ignoring or overwriting user defined configuration values for deserializers #189

Open
Crim opened this issue Sep 22, 2019 · 1 comment
Open

Lets add warning log msgs when ignoring or overwriting user defined configuration values for deserializers #189

Crim opened this issue Sep 22, 2019 · 1 comment
Labels
good first issue

Comments

@Crim
Copy link
Collaborator

Crim commented Sep 22, 2019

The following two places we silently overwrite or ignore user supplied configuration properties for deserializers. For debugging purposes we should emit warnings when we either overwrite or ignore user supplied configuration options.

https://github.com/SourceLabOrg/kafka-webview/blob/master/kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/manager/kafka/KafkaConsumerFactory.java#L130-L143

https://github.com/SourceLabOrg/kafka-webview/blob/master/kafka-webview-ui/src/main/java/org/sourcelab/kafka/webview/ui/manager/kafka/config/DeserializerConfig.java#L88-L93
@ramya-ramakrishna
Copy link

#193
Fixed this issue , kindly have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Crim @ramya-ramakrishna