Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove: remove two useless key bindings #2587

Closed

Conversation

NamelessUzer
Copy link
Contributor

@NamelessUzer NamelessUzer commented Feb 15, 2019

Remove: remove two useless key bindings and the two corresponding functions for them.

PR Prelude

Thank you for working on SpaceVim! :)

Please complete these steps and check these boxes before filing your PR:

  • I have read and understood SpaceVim's CONTRIBUTING document.
  • I have read and understood SpaceVim's CODE_OF_CONDUCT document.
  • I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful?

spacevim = 'SpaceVim'
spacevim = "SpaceVim"
spacevim = """SpaceVim is a very
good Vim distribution."""
  1. Please copy the code above, then paste it in a *.py file.
  2. Set the cursor on the words - 3 Spacevim and Vim in turn then press SPC j s or SPC j S.
  3. Then you will find the problems: these 2 key bindings works not properly for Python string.
  4. These 2 key bindings works well for Vim string at least. So I guess it's a bug of Vim.
  5. In my opinion, they have a limited effect and are diffcult to implement, so I remove these two useless key bindings and the two corresponding functions for them.

@wsdjeg
Copy link
Member

wsdjeg commented Feb 16, 2019

I do not want remove this feature, and instead following key binding is usefull and in same group

Joining and splitting

Key binding Description
J join the current line with the next line
SPC j k go to next line and indent it using auto-indent rules
SPC j n split the current line at point, insert a new line and auto-indent
SPC j o split the current line at point but let point on current line
SPC j s split a quoted string or s-expression in place
SPC j S split a quoted string or s-expression, insert a new line and auto-indent

@NamelessUzer
Copy link
Contributor Author

OK. Follow your opinion, I close this PR. But I still suggest that fix this bug for Python string or unmap these key bindings for Python file and any other file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants