-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Coveralls to the build #7
Comments
Coveralls requires access to the organization the same as Travis. Could I get a 👍 from the core maintainers before adding it? Cc @kwltrs @gbrownlee @antidecaf |
Is this issue not resolved, @wkillerud ? |
No @gbrownlee - I wanted to get a go-ahead before opening up the org to Coveralls 😄 Anders has given a thumbsup and I take it your comment is a blessing to |
This commit introduces a new test script for CI that includes coverage reporting with Jest and Coveralls. It also uses Jests `--ci` option. From the docs: > When this option is provided, Jest will assume it is running in a CI > environment. This changes the behavior when a new snapshot is > encountered. Instead of the regular behavior of storing a new > snapshot automatically, it will fail the test and require Jest to be > run with `--updateSnapshot`. Travis will use this new CI script so we get Coveralls reporting on pull requests.
This commit introduces a new test script for CI that includes coverage reporting with Jest and Coveralls. It also uses Jests `--ci` option. From the docs: > When this option is provided, Jest will assume it is running in a CI > environment. This changes the behavior when a new snapshot is > encountered. Instead of the regular behavior of storing a new > snapshot automatically, it will fail the test and require Jest to be > run with `--updateSnapshot`. Travis will use this new CI script so we get Coveralls reporting on pull requests.
This commit introduces a new test script for CI that includes coverage reporting with Jest and Coveralls. It also uses Jests `--ci` option. From the docs: > When this option is provided, Jest will assume it is running in a CI > environment. This changes the behavior when a new snapshot is > encountered. Instead of the regular behavior of storing a new > snapshot automatically, it will fail the test and require Jest to be > run with `--updateSnapshot`. The result from the coverage report is piped to a `coveralls` util which takes care of submitting the coverage report to Coveralls and further on to Github. Travis will use this new CI script so we get Coveralls reporting on pull requests.
I say fail the build if the test coverage decreases. |
This commit introduces a new test script for CI that includes coverage reporting with Jest and Coveralls. It also uses Jests `--ci` option. From the docs: > When this option is provided, Jest will assume it is running in a CI > environment. This changes the behavior when a new snapshot is > encountered. Instead of the regular behavior of storing a new > snapshot automatically, it will fail the test and require Jest to be > run with `--updateSnapshot`. The result from the coverage report is piped to a `coveralls` util which takes care of submitting the coverage report to Coveralls and further on to Github. Travis will use this new CI script so we get Coveralls reporting on pull requests.
I'm thinking not allowing any decrease at all may be a bit harsh, but we can give it a try and see if it causes unnecessary problems. |
infra: Add coverage reporting to CI build (#7)
Coveralls is a really nice thing for monitoring test coverage and is relatively easy to integrate with Travis. It's also free for opensource projects. It will find and comment on pull requests indicating if the coverage has gone up or down, an example of what that looks like can be seen here.
The text was updated successfully, but these errors were encountered: