Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Coveralls to the build #7

Closed
wkillerud opened this issue Feb 26, 2018 · 5 comments
Closed

Add Coveralls to the build #7

wkillerud opened this issue Feb 26, 2018 · 5 comments
Assignees
@wkillerud
Labels
💻 technical Technical or infrastructure issue

Comments

@wkillerud
Copy link
Contributor

Coveralls is a really nice thing for monitoring test coverage and is relatively easy to integrate with Travis. It's also free for opensource projects. It will find and comment on pull requests indicating if the coverage has gone up or down, an example of what that looks like can be seen here.
@wkillerud wkillerud added the 💻 technical Technical or infrastructure issue label Feb 26, 2018
@wkillerud
Copy link
Contributor Author

Coveralls requires access to the organization the same as Travis. Could I get a 👍 from the core maintainers before adding it? Cc @kwltrs @gbrownlee @antidecaf

@wkillerud wkillerud self-assigned this Feb 26, 2018
@gbrownlee
Copy link
Contributor

Is this issue not resolved, @wkillerud ?

@selbekk selbekk added 🚀 ffe FFE related questions and removed 🚀 ffe FFE related questions labels Mar 6, 2018
@wkillerud
Copy link
Contributor Author

No @gbrownlee - I wanted to get a go-ahead before opening up the org to Coveralls 😄 Anders has given a thumbsup and I take it your comment is a blessing to :shipit: as well? 😉

wkillerud added a commit that referenced this issue Mar 8, 2018
@wkillerud
infra: Add coverage reporting to CI build (#7)
369d1bd 
This commit introduces a new test script for CI that includes coverage
reporting with Jest and Coveralls. It also uses Jests `--ci` option.
From the docs:

> When this option is provided, Jest will assume it is running in a CI
> environment. This changes the behavior when a new snapshot is
> encountered. Instead of the regular behavior of storing a new
> snapshot automatically, it will fail the test and require Jest to be
> run with `--updateSnapshot`.

Travis will use this new CI script so we get Coveralls reporting on
pull requests.
wkillerud added a commit that referenced this issue Mar 8, 2018
@wkillerud
infra: Add coverage reporting to CI build (#7)
8fda25b 
This commit introduces a new test script for CI that includes coverage
reporting with Jest and Coveralls. It also uses Jests `--ci` option.
From the docs:

> When this option is provided, Jest will assume it is running in a CI
> environment. This changes the behavior when a new snapshot is
> encountered. Instead of the regular behavior of storing a new
> snapshot automatically, it will fail the test and require Jest to be
> run with `--updateSnapshot`.

Travis will use this new CI script so we get Coveralls reporting on
pull requests.
wkillerud added a commit that referenced this issue Mar 8, 2018
@wkillerud
infra: Add coverage reporting to CI build (#7)
388ab97 
This commit introduces a new test script for CI that includes coverage
reporting with Jest and Coveralls. It also uses Jests `--ci` option.
From the docs:

> When this option is provided, Jest will assume it is running in a CI
> environment. This changes the behavior when a new snapshot is
> encountered. Instead of the regular behavior of storing a new
> snapshot automatically, it will fail the test and require Jest to be
> run with `--updateSnapshot`.

The result from the coverage report is piped to a `coveralls` util
which takes care of submitting the coverage report to Coveralls and
further on to Github.

Travis will use this new CI script so we get Coveralls reporting on
pull requests.
@wkillerud wkillerud mentioned this issue Mar 8, 2018
Merged
@selbekk
Copy link
Contributor

selbekk commented Mar 8, 2018

I say fail the build if the test coverage decreases.

wkillerud added a commit that referenced this issue Mar 8, 2018
@wkillerud
infra: Add coverage reporting to CI build (#7)
d1dac0e 
This commit introduces a new test script for CI that includes coverage
reporting with Jest and Coveralls. It also uses Jests `--ci` option.
From the docs:

> When this option is provided, Jest will assume it is running in a CI
> environment. This changes the behavior when a new snapshot is
> encountered. Instead of the regular behavior of storing a new
> snapshot automatically, it will fail the test and require Jest to be
> run with `--updateSnapshot`.

The result from the coverage report is piped to a `coveralls` util
which takes care of submitting the coverage report to Coveralls and
further on to Github.

Travis will use this new CI script so we get Coveralls reporting on
pull requests.
@wkillerud
Copy link
Contributor Author

I'm thinking not allowing any decrease at all may be a bit harsh, but we can give it a try and see if it causes unnecessary problems.

wkillerud added a commit that referenced this issue Mar 8, 2018
@wkillerud
Merge pull request #63 from SpareBank1/7-coveralls
359dd64 
infra: Add coverage reporting to CI build (#7)
@wkillerud wkillerud mentioned this issue Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkillerud wkillerud

Labels
💻 technical Technical or infrastructure issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbrownlee @wkillerud @selbekk