- Moved targetPerson null check after personActionId and personGuid c…

…hecks
SparkDevNetwork · Jan 18, 2024 · 4d453fc · 4d453fc
1 parent 55ad663
commit 4d453fc
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/RockWeb/Blocks/Finance/ContributionStatementGenerator.ascx.cs b/RockWeb/Blocks/Finance/ContributionStatementGenerator.ascx.cs
@@ -116,13 +116,6 @@ private void DisplayResults()
         {
             Person targetPerson = CurrentPerson;
 
-            if ( targetPerson == null )
-            {
-                Response.StatusCode = ( int ) HttpStatusCode.BadRequest;
-                Response.Write( "Invalid Person" );
-                Response.End();
-            }
-
             RockContext rockContext = new RockContext();
 
             var statementYear = PageParameter( PageParameterKey.StatementYear ).AsIntegerOrNull() ?? RockDateTime.Now.Year;
@@ -154,6 +147,13 @@ private void DisplayResults()
                 }
             }
 
+            if ( targetPerson == null )
+            {
+                Response.StatusCode = ( int ) HttpStatusCode.BadRequest;
+                Response.Write( "Invalid Person" );
+                Response.End();
+            }
+
             FinancialStatementGeneratorOptions financialStatementGeneratorOptions = new FinancialStatementGeneratorOptions();
             var startDate = new DateTime( statementYear, 1, 1 );
             financialStatementGeneratorOptions.StartDate = startDate;