Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group's GroupTypeRole MaxCount not honored #1275

Closed
nairdo opened this issue Oct 19, 2015 · 3 comments
Closed

Group's GroupTypeRole MaxCount not honored #1275

nairdo opened this issue Oct 19, 2015 · 3 comments
Assignees
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@nairdo
Copy link
Member

nairdo commented Oct 19, 2015

As mentioned here http://www.rockrms.com/Rock/Ask/Troubleshooting/Questions/809

  • perhaps the GroupFinder block should not show groups that are at their max member (active) count
  • the externally facing GroupRegistration block is not checking the group's MaxCount (active members) before adding the new person.

(The GroupDetail block does check the MaxCount).

@nairdo nairdo added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Oct 19, 2015
@nateh777
Copy link
Contributor

Any update on this issue? I just noticed it in my questions months later and see that it has not been resolved yet. Haven't tried it yet but I am going to be starting on this area again in June.

@jonedmiston
Copy link
Member

As a proposal then we should:

  • GroupFinder Block: Add a block setting 'Hide Overcapacity Groups' (default true?)
  • Group Registration Block: Add a block setting 'Prevent Overcapacity Registrations' - The difficult part about this is there may be room for one individual but I believe you can also register a spouse. What to do in that case? Show a warning "Group near capacity. Only one individual can register."?

Note we now have a group capacity setting on groups to consider also.

Give me your thoughts and we can see about getting this in for v5 (though we're very close to wrapping that up).

@nateh777
Copy link
Contributor

I think your suggestions sound great. I would default to true on hiding overcapacity groups because that is what I expected to happen. For the with spouse registration I think the warning is acceptable.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Aug 3, 2016
azturner added a commit that referenced this issue Aug 19, 2016
…pcapacitycheck

+ GroupFinder and GroupRegistration now honor a group's GroupCapacity and GroupTypeRole.MaxCount (Fixes #1275).
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

5 participants