Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use SendSMS Workflow Action with Group in 7.x #2747

Closed
1 task done
cabal95 opened this issue Feb 7, 2018 · 0 comments
Closed
1 task done

Cannot use SendSMS Workflow Action with Group in 7.x #2747

cabal95 opened this issue Feb 7, 2018 · 0 comments
Assignees
Labels
Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v7.3
Milestone

Comments

@cabal95
Copy link
Member

cabal95 commented Feb 7, 2018

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

It looks like 7.0 refactored the way the SendSMS handles the merge fields when working with a group. From what I can tell it passes the mergeFields variable to the RecipientData object, which maintains a reference to it instead of a copy of it. Then the SendSMS action adds a "Person" object to the MergeFields. When using a Group, this causes a "An item with the same key has already been added." error because the dictionary already has a "Person" object from the previous loop through the group members.

Reported on Slack, confirmed on prealpha.

Steps to Reproduce

  1. Create Workflow with SendSMS action.
  2. Set the target to be a group with 2 or more people in it.
  3. Run the workflow.

Expected behavior:

Message should be sent to multiple people.

Actual behavior:

Workflow throws an error.

Versions

  • Rock Version: 7.0, 8.0
  • Client Culture Setting: en-US
@cabal95 cabal95 added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Priority: High Affects most production Rock installs in a way that will be noticed. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. labels Feb 7, 2018
@MikeDPeterson MikeDPeterson self-assigned this Feb 8, 2018
MikeDPeterson added a commit that referenced this issue Feb 8, 2018
…ient is a group with multiple people in it. (Fixes #2747)
@crayzd92 crayzd92 added this to the v7 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Communications Related to Rock Communications: Email, SMS, MMS, Push Notifications, etc. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v7.3
Projects
None yet
Development

No branches or pull requests

3 participants