Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data View not actually required in Data View badge type configuration #3074

Closed
1 task done
mikejed opened this issue Jun 18, 2018 · 0 comments
Closed
1 task done

Data View not actually required in Data View badge type configuration #3074

mikejed opened this issue Jun 18, 2018 · 0 comments
Assignees
@shivambareria
Labels
Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: UI Related to visual design. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v8.1
Milestone
v8

Comments

@mikejed
Copy link
Contributor

mikejed commented Jun 18, 2018

Before completing your first issue we highly recommend reading this post on Effective Ways To Get Help from Maintainers.

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

When creating an In Data View type badge, selecting the data view from the menu is supposed to be (and should be) required. However, you can click Save while that box is blank and it will happily save

Steps to Reproduce

  1. Create a new In Data View Person Badge
  2. Provide a name (but not a Data View)
  3. Click Save

Expected behavior:

It should not save; rather it should give you a notice that you haven't provided a required item

Actual behavior:

It saves

Versions

  • Rock Version: v7.4, v8 prealpha
  • Client Culture Setting: EN-US
@mikejed mikejed added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: UI Related to visual design. Priority: Low Affects a small number of Rock installations and will not be noticed by most users. labels Jun 18, 2018
shivambareria added a commit that referenced this issue Jun 29, 2018
@shivambareria
+ Fixed In Data View badge type to respect the required validation fo…
e0d8123 
…r data view picker. ( Fixes #3074)
MikeDPeterson added a commit that referenced this issue Aug 13, 2018
@MikeDPeterson
+ Fixed In Data View badge type to respect the required validation fo…
bf78981 
…r data view picker. ( Fixes #3074)

(cherry picked from commit e0d8123)
@crayzd92 crayzd92 added this to the v8 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivambareria shivambareria

Labels
Priority: Low Affects a small number of Rock installations and will not be noticed by most users. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: UI Related to visual design. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v8.1
Projects
None yet
Milestone
v8
Development

No branches or pull requests
4 participants
@jonedmiston @mikejed @shivambareria @crayzd92