Group Scheduler Exposes Inactive Schedules

[JimMichael]

Description

Schedules that are on groups but configured as Inactive still show up as schedule-able on both the internal Group Scheduler as well as the external Schedule Toolbox.

Steps to Reproduce

1. Identify a serving team group with a schedule
2. Go to Admin | General | Schedules and find/mark that schedule as inactive.
3. Go to People | Group Scheduling | Group Scheduler and choose your group
4. Observe that the inactive schedule shows up.
5. Observe same on external /scheduletoolbox page.

Expected behavior:

Inactive schedules would be ignored by the group scheduling tools and not exposed.

Actual behavior:

They show up just like any other schedule. Why this is important to us is that we use completely different "Holiday" schedules for Christmas and Easter on our kids check-in and serving team groups. To date, we just leave those schedules on all the groups but they are "dormant" because their schedule times are all in the past (once the holiday service is over). We then update them with new active days when the next holiday rolls around.

We quickly discovered that these active (but not-causing-any-harm) schedules would not play well with Group Scheduling, because that tool exposes them... so we thought "ok, so we'll just inactive these schedules until we need them" but that doesn't work, either. Currently the only way to have a schedule NOT show in the group scheduling tools is to remove it completely from the group... but this causes huge amounts of work deleting and re-adding schedules to many groups every time a holiday comes around.

We consider it incorrect behavior to expose inactive data like this to end users.

Versions

• Rock Version: 9.4, 10.1