Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Board modal doesn't render markdown in comments field #4563

Closed
1 task done
MichaelAllen opened this issue Jan 24, 2021 · 1 comment
Closed
1 task done
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v12.1
Milestone

Comments

@MichaelAllen
Copy link
Contributor

MichaelAllen commented Jan 24, 2021

Prerequisites

Description

The "Connection Request Detail" block renders markdown in the "comments" field, but the modal view on the "Connection Request Board" block shows that field as plain text. We use markdown in that field to add links to other parts of Rock.

Steps to Reproduce

  1. Create a connection request with this markdown in the comments field: [Link Test](https://google.com)
  2. View the request on the Connection Request Detail page (https://rock.rocksolidchurchdemo.com/page/408?ConnectionRequestId=1) and notice it renders as a clickable link.
  3. View the same request by opening it in the connection board block and notice the markdown is not rendered.

Expected behavior:

Markdown in the comments should be rendered correctly.

^ Connection Detail Page

Actual behavior:

Markdown in the comments is rendered as plain text.

^ Connection Board Modal

Versions

  • Rock Version: v1.12.0.10
  • Client Culture Setting: en-US
@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Jan 29, 2021
@nairdo nairdo added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Jan 29, 2021
@nairdo nairdo removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Feb 1, 2021
@nairdo
Copy link
Member

nairdo commented Feb 1, 2021

Fixed via 6a4f6e9.

@crayzd92 crayzd92 added this to the v12 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. x-Fixed in v12.1
Projects
None yet
Development

No branches or pull requests

5 participants