Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.1 ALPHA - EmailForm Block No Longer Works #4582

Closed
JimMichael opened this issue Feb 5, 2021 · 4 comments
Closed

12.1 ALPHA - EmailForm Block No Longer Works #4582

JimMichael opened this issue Feb 5, 2021 · 4 comments

Comments

@JimMichael
Copy link
Collaborator

JimMichael commented Feb 5, 2021

Description

This is related to #4550 but I'm entering it as new since this is new behavior as of 12.1 alpha.

The "fixed in 12.1" for the issue linked above did not work. Now the EmailForm block does not work at all. It no longer throws an exception, but also no longer delivers any email.

Steps to Reproduce

  1. Put EmailForm block on a page
  2. Configure appropriate to/from addresses.
  3. Send the form
  4. Observe the email never arrives

Expected behavior:

EmailForm block would work as it did prior to 12.0

Actual behavior:

It doesn't work at all, now. Note that because the exception it was causing in v12 was related to the "No Legacy" global attribute setting, I did try it with "Legacy with warning" instead, but it still did not deliver.

Versions

  • Rock Version: 12.1
@mikedotmundy
Copy link

mikedotmundy commented Feb 5, 2021

This DOES work for me on v12.1. I had no issues and it did not cause any exceptions. I use Mailgun SMTP Transport.

@JimMichael
Copy link
Collaborator Author

After further testing, I've found that it only seems to be a problem when we're using the SendGrid HTTP transport. I tried some others (all pointing at our SendGrid account) and here's the results:

SendGrid HTTP: NO email arrives
SendGrid SMTP (old plugin): email arrives
SMTP: email arrives.

NO Exceptions are thrown in any of the three scenarios. Hopefully that helps narrow down the issue.

@matthewbronkema
Copy link
Contributor

@JimMichael can you enable the Save Communication History on the email form and then retry your SendGrid HTTP test? I am hoping the results saved in the communication will give us some more troubleshooting information.

@JimMichael
Copy link
Collaborator Author

@matthewbronkema Enabling Save Communication History causes the email to be delivered successfully. With it disabled again, the mail never arrives.

After further testing, I've also discovered that this is not isolated to the EmailForm block. We were also seeing "random" workflows that use Send Email action failing (but again, only when using SendGrid HTTP transport). I looked at a few of these just now, and sure enough... the ones that work already have Save Communication History enabled in the action, and the ones that fail to deliver, don't.

So there's definitely something wonky going on with SendGrid HTTP transport when save comm history is disabled.

matthewbronkema added a commit that referenced this issue Feb 9, 2021
…that required the Save Communication option to be checked for emails to actually be sent via the Send Grid API. (Fixes #4582)
nairdo added a commit to SparkDevNetwork/Rock-UpdatePackageBuilder that referenced this issue Feb 9, 2021
richarddubay pushed a commit to NewSpring/Rock that referenced this issue Aug 11, 2021
…that required the Save Communication option to be checked for emails to actually be sent via the Send Grid API. (Fixes SparkDevNetwork#4582)
richarddubay pushed a commit to NewSpring/Rock that referenced this issue Aug 11, 2021
…that required the Save Communication option to be checked for emails to actually be sent via the Send Grid API. (Fixes SparkDevNetwork#4582)
@crayzd92 crayzd92 added this to the v12 milestone Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants