Workflow Forms no longer respect the "no validation" button type

[chrismcgrath]

Description

Selecting the Primary (no validation) Button Type on a Workflow Form does not prevent the form from requiring a value in a required field. Noticed first in v12.2 but confirmed it's happening in 12.4 on rock.rocksolidchurchdemo.com.

I created this Test Button Validation workflow at https://rock.rocksolidchurchdemo.com/page/136?workflowTypeId=24 but if it's been deleted or you want to test on another install, here is the workflow, just remove .txt from the filename and import.
Test Button Validation_202106101146.json.txt

Steps to Reproduce

1. Create a Workflow with an attribute and an entry form.
2. Make the attribute editable on the entry form.
3. Make two buttons on the form, a Submit button with Primary button type and a Cancel button with Primary (no validation) button type.
4. Run the workflow
5. Click the cancel button

Expected behavior:

The form should submit/cancel successfully.

Actual behavior:

The form says that the required field is required.

Interestingly, the validation displays differently when using the Submit button or the Cancel button.

Submit button:

Cancel button:

Versions

• Rock Version: Rock McKinley 12.2 (1.12.2.2), Rock McKinley 12.4 (1.12.4.1)
• Client Culture Setting: en-US

[nairdo]

@chrismcgrath I was able to dig into this one and see what was going on. It turns out the core/stock "Cancel" button is special and has extra stuff that happens behind the scenes -- namely that it is specifically tuned to disable validation when it is used in the workflow form. (To put it another way: there is no visible/administrative surface to control whether a button should 'cause validation' in the Button HTML defined type.)

I also reviewed this with the design team to conclude that this is not actually a bug, but I would understand if you decided you wanted to open a feature request over at http://community.rockrms.com/Ideas to perhaps enhance the stock HTML Buttons with a new attribute or something to control that feature.