Exception occurs when merging two people with scheduling preferences for same group

[azturner]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?

Description

An exception will occur If you try to merge two people who both belong to the same group and both have created a schedule preference for that group.

While the exception does prevent the merge, the bigger issue is that this leaves one of the person records without a PersonAlias record because their person alias records will now point to the other person, and this causes other problems to occur (i.e. Rock Cleanup job fails on person records and thus does not update giving ids).

Steps to Reproduce

1. Create two person records
2. Add both records to same group with group scheduling enabled
3. Impersonate both people and add a scheduling preference for the group
4. Merge both person records

Expected behavior:

Records are merged successfully

Actual behavior:

Exception occurs and Person record is left in state without an associated Person Alias record

Versions

• Rock Version: 12.7
• Client Culture Setting: en-US

┆Attachments: image.png

[azturner]

Also, when trying to debug this issue, noticed this line of SQL which seems odd: https://github.com/SparkDevNetwork/Rock/blob/develop/database/Procedures/spCrm_PersonMerge.sql#L96