Benevolence Request Detail Shows Genderless Unknown Photo Even if Gender Exists

[leahjennings]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Did you perform a search at https://github.com/issues?q=is%3Aissue+user%3ASparkDevNetwork+-repo%3ARock to see if your bug or enhancement is already reported?
  • Can you reproduce the problem on a fresh install or the demo site?
  • Did you include your Rock version number and client culture setting?

A Picture Is worth a Thousand Words

Description

When a Benevolence Request Requestor is assigned to a profile that has a Gender set but not a photo, the Benevolence Request Detail block shows the genderless unknown photo instead of the correct Gender unknown photo.

Steps to Reproduce

1. Identify (or create) a profile that has a gender set but no profile photo (I created a male Tony Stark in this example)
2. Go to Finance > Benevolence
3. Create a new Benevolence Request
4. Set the Requestor to the profile identified/created in the first step
5. Set the Request Status and Description of Request to any value (it's irrelevant for the bug being reported)
6. Save the Benevolence Request

Expected behavior:

I would expect the Benevolence Request Detail block to show an unknown gender photo if the Requestor has a Gender set on their profile.

Actual behavior:

The genderless unknown photo is always shown if there's no profile photo on the Requestor's profile, even if there is a Gender set.

Versions

• Rock Version: [Rock McKinley 13.7 (1.13.7.1)]
• Client Culture Setting: [en-US]