Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication History Recipient Count Filter is sticky #5190

Closed
stevekleinliquid opened this issue Oct 4, 2022 · 1 comment
Closed

Communication History Recipient Count Filter is sticky #5190

stevekleinliquid opened this issue Oct 4, 2022 · 1 comment
Labels
Fixed in v14.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@stevekleinliquid
Copy link

stevekleinliquid commented Oct 4, 2022

Description

On the Communication History page, once the recipient count range is set, it cannot be permanently cleared.
Screen Shot 2022-10-04 at 4 07 07 AM

Steps to Reproduce

  1. Go to the Communication History page, open filter options, set the recipient count range (e.g. 100 to 200) and click on Apply Filter to filter.
  2. Open filter options and clear the recipient count range (i.e. remove numbers from both fields) and click on Apply Filter to filter.
  3. Navigate to another page (e.g. Group Viewer) and then back to Communication History.

Expected behavior:

Clearing the recipient count range should remove that part of the filter. Those values should remain cleared until they are set to something else.

Actual behavior:

Once set, the recipient count range cannot be permanently cleared. Note that while you are on the Communication History page, you can clear the recipient count range and this setting will be honored, although the last entered range will be displayed at the top of your results.

@leahjennings came up with a clever workaround - by setting the range to from 1 (to blank), you can essentially clear the filter.

Versions

  • Rock Version: [12.7]
  • Client Culture Setting: [en-us]
@asdf1nit
Copy link

asdf1nit commented Oct 4, 2022

I can confirm, we have the same issue on v13.6

@leahjennings leahjennings added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Oct 4, 2022
@croske croske closed this as completed in 13f31ff Jan 3, 2023
croske added a commit that referenced this issue Jan 10, 2023
…o allow blank Recipient Counts. (Fixes #5190)

(cherry picked from commit 13f31ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v14.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

4 participants