Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in TransactionList.ascx.cs #5312

Closed
1 task done
nlBayside opened this issue Feb 14, 2023 · 0 comments
Closed
1 task done

Typo in TransactionList.ascx.cs #5312

nlBayside opened this issue Feb 14, 2023 · 0 comments
Labels
Fixed in v15.0 Topic: Finance Related to finance. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@nlBayside
Copy link
Contributor

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Typo in TransactionList.ascx.cs. The object is setting EntityId to the EntityTypeId property. I'm guessing this is not intended behavior and it is just a typo.

Expected Behavior

EntityTypeId is set using the EntityTypeId property.

Actual Behavior

EntityTypeId is set using EntityId

Steps to Reproduce

  • Check TransactionList.ascx.cs Line 1627

Rock Version

Since 2019

Client Culture Setting

en-us
@notGerryMiller notGerryMiller mentioned this issue Mar 23, 2023
Merged
10 tasks
@shauncummings shauncummings added Topic: Finance Related to finance. Fixed in v15.0 Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Apr 14, 2023
shauncummings pushed a commit that referenced this issue Apr 14, 2023
@notGerryMiller @shauncummings
+ (Finance) Fixed a bug with data on the TransactionList block. (Fixes …
c53250f 
…#5312)

EntityTypeId = a.EntityId should have been EntityTypeId = a.EntityTypeId

(cherry picked from commit 655dd61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in v15.0 Topic: Finance Related to finance. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shauncummings @nlBayside