Post-filter Transformation for Parents not honoring Archived status

[erickpece]

Please go through all the tasks below

• Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

I set up a Data View to show Parents for my own family in Rock. It resulted in showing a few extra people who were listed as part of our family, but have been archived for some time.

In the database, these people are still listed as members of our family, but the IsArchived flag is set to true. However, they're still returned by the code that handles the parent transform.

I think that the BuildExpression method inside ParentTransform.cs probably just needs an additional filter to exclude anyone who is archived, but I don't have an environment set up to test this scenario.

Expected Behavior

Adults in a family with IsArchived set to false should be the only ones included in the Parent Transform.

Actual Behavior

All adults in a family are included in the Parent Transform.

Steps to Reproduce

1. Create a new Family in Rock with 2 adults and 1 child.
2. Create a Person Data View that filters only that family (for instance, using the last name) and set the Post-filter Transformation to Parents.
3. Observe that only the 2 adults show up in the Data View.
4. Archive a member of the family. I'm not sure how we originally did this, but going to the Group Viewer and manually entering the Group Id to match the family, then marking the adult inactive seems to work. (tested at https://rock.rocksolidchurchdemo.com/)
5. Observe that the 2 adults still show up in the Data View.

Rock Version

Rock McKinley 14.0 (1.14.0.18)

Client Culture Setting

en-US