Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd behavior when Saving Transaction #5348

Closed
1 task done
mikedotmundy opened this issue Mar 17, 2023 · 1 comment
Closed
1 task done

Odd behavior when Saving Transaction #5348

mikedotmundy opened this issue Mar 17, 2023 · 1 comment
Labels
Fixed in v14.3 Fixed in v15.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Finance Related to finance.

Comments

@mikedotmundy
Copy link

mikedotmundy commented Mar 17, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When saving and adding a new Transaction to a Batch, after adding your amount, if you do not click outside of the Amount field before saving, you will be greeted with a message stating you have not added an amount. This behavior is the same for the Save, Save Then Add, and Save Then View Batch buttons.

Screenshot 2023-03-17 at 16 17 11

This is a minor bug, however this is not normal behavior like in other areas of Rock.

The attached video will hopefully explain a little better what the issue is.

Screen.Recording.2023-03-17.at.16.16.27.mov

In our instance, this is also generating an exception. However, I did not see an exception created when testing on the demo site.
Screenshot 2023-03-17 at 16 35 46

  at System.Convert.FromBase64_Decode(Char* startInputPtr, Int32 inputLength, Byte* startDestPtr, Int32 destLength)
   at System.Convert.FromBase64CharPtr(Char* inputPtr, Int32 inputLength)
   at System.Convert.FromBase64String(String s)
   at Rock.Web.UI.RockHiddenFieldPageStatePersister.Load() in C:\Github\Rock14\Rock\Web\UI\RockHiddenFieldPageStatePersister.cs:line 112
   at System.Web.UI.Page.LoadPageStateFromPersistenceMedium()
   at System.Web.UI.Page.LoadAllState()
   at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

Expected Behavior

I would expect that I do not have to click out of the Amount field before saving the Transaction.

Actual Behavior

You must click outside the Amount field before saving the Transaction.

Steps to Reproduce

  • Add a new Batch.
  • Add a Transaction to the new Batch. For this first transaction, you will not see the issue. However, input all the required info and then click Save Then Add.
  • Now, on the 2nd transaction, select a Person.
  • Enter a dollar amount in the Amount field, and DO NOT click on the page. Click Save Then Add (or any of the "Save" buttons).
  • See the modal pop up stating that the amount you entered is still registering $0.
  • You can repeat the above steps, only instead make sure to click anywhere after entering an amount, and then click Save. You will notice it worked properly.

Rock Version

v14.1, v14.2, v15.0

Client Culture Setting

en-US

@nairdo nairdo added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Finance Related to finance. Fixed in v14.3 labels Mar 31, 2023
shivambareria added a commit that referenced this issue May 25, 2023
…ction in simple mode while Saving Transaction. (Fixes #5348)
@mikedotmundy
Copy link
Author

This is still an issue for us in v15.1

Here is a screenshot of the exception:

Screenshot 2023-07-17 at 20 45 44

Stack trace:

   at System.Convert.FromBase64_Decode(Char* startInputPtr, Int32 inputLength, Byte* startDestPtr, Int32 destLength)
   at System.Convert.FromBase64CharPtr(Char* inputPtr, Int32 inputLength)
   at System.Convert.FromBase64String(String s)
   at Rock.Web.UI.RockHiddenFieldPageStatePersister.Load() in \Rock\Web\UI\RockHiddenFieldPageStatePersister.cs:line 112
   at System.Web.UI.Page.LoadPageStateFromPersistenceMedium()
   at System.Web.UI.Page.LoadAllState()
   at System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v14.3 Fixed in v15.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Finance Related to finance.
Projects
None yet
Development

No branches or pull requests

3 participants
@nairdo @mikedotmundy and others