Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's something about Ted Decker on tablets (it's a date string problem) #535

Closed
ElimAdmin opened this issue Sep 22, 2014 · 7 comments
Closed
Assignees
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@ElimAdmin
Copy link

On a PC this problem does not occur.
On a tablet the following happens:

On the demo site you can search for "Gre" and select any member of the Grey family as many times as you like, and they are correctly displayed in the Person screen. These persons have nothing loaded expect the very basic details.

But as soon as you select Decker, Ted or Decker, Noah the Person page will not load. There is then no way to recover and the web tab must be closed.

This results in a "String was not recognized as a valid DateTime" exception. (Refer to the 53+ count on this Exception in the demo site.) The Exception count goes up whenever I try this.

This happened on both my Galaxy Note 8.0 and Galaxy Tab 8.9 (different Android versions).

@ElimAdmin
Copy link
Author

This is not unique to Android. It also happens on a iphone.

@ElimAdmin ElimAdmin reopened this Sep 23, 2014
@ElimAdmin ElimAdmin changed the title There's something about Ted Decker on Android tablets (it's a date string problem) There's something about Ted Decker on tablets (it's a date string problem) Sep 23, 2014
@azturner
Copy link
Contributor

This is likely due to a date-format issue with devices not using an "en-US" culture and the sample data. Rock is trying to read/parse date attributes that are stored in "en-US" format, but trying to parse them using the device/browser's format.

Rock needs to be updated to store and parse date attribute values using a consistent format because each visitor to a Rock website may be using a different culture.

@ElimAdmin , to verify this, are you able to temporarily change the culture for those devices/browsers that are not working to the "en-US" culture and see if you still have the same issue?

@ElimAdmin
Copy link
Author

Setting the date format on the Galaxy Note 8 to US did not resolve the issue.
The problem is caused by/in the 'Attending Duration' badge. Turn off the badge: no problem on the tablet. Turn it back on, and the page throws an exception.

@jonedmiston jonedmiston self-assigned this Sep 25, 2014
@ElimAdmin
Copy link
Author

@azturner Yes: this is a web browser culture issue. I didn't know how to change the culture before.

In the demo site dates previously entered will display correctly with a browser culture of en-US.

dateformat1

dateformat2

But if the culture is changed to en-GB then dates will no longer display, and the badge 'Attending Duration' no longer displays. (It does not throw an exception now.)

dateformat3

dateformat4

But note that if the date is entered in the en-GB culture (as I did for the Baptism Date), it will subsequently display correctly when the browser is changed back to either en-US or en-GB.

(So will this be an issue for us when we import our data? In NZ we use a DD/MM/YYYY date format, but we have it ready in the MM/DD/YYYY ready for import. )

@ElimAdmin
Copy link
Author

@azturner Looks like this is just a problem with the sample data. Dates I've entered in our own site switch correctly between cultures. So I think this issue can be closed. If there is an issue with the data import I'll raise it in Excavator.

@azturner
Copy link
Contributor

@nairdo , can you update the sampledata.xml file so that date attributes are in the ISO 8601 formatted values ("o").

@azturner azturner assigned nairdo and unassigned jonedmiston Oct 27, 2014
@nairdo nairdo added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Nov 7, 2014
nairdo added a commit that referenced this issue Nov 7, 2014
@nairdo
Copy link
Member

nairdo commented Nov 7, 2014

I also just pushed the new sample data file out to the blob storage so it's live now.

@nairdo nairdo closed this as completed Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

4 participants