Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow form is displayed to user and can be completed even though it hasn't been activated yet. #5363

Closed
1 task done
azturner opened this issue Mar 29, 2023 · 5 comments
Labels
Fixed in v16.1 Topic: Workflows Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@azturner
Copy link
Contributor

azturner commented Mar 29, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Workflow Form is displayed and can be completed even though that form's action has not been activated yet.

Expected Behavior

A workflow form should not be displayed to user unless that action has been activated in the workflow

Actual Behavior

If activity contains a form action, that form will be displayed to user even if the form's action has not yet been activated.

Steps to Reproduce

Create a new workflow with one activity
Add a Delay action to that activity and configure it to delay 100 mins
Add a Form action to that same activity
Save and run the workflow.

A message should be displayed indicating that there's nothing to do because delay action would not of been completed yet, however, the form is displayed and can be completed. Once you submit form, the workflow is completed. You can see this in details of workflow...

image

Rock Version

14.1, 15.0 (prealpha)

Client Culture Setting

en-US

@azturner
Copy link
Contributor Author

Any update on this issue? We're seeing workflow issues because forms are being completed before they're supposed to be.

@nairdo
Copy link
Member

nairdo commented Apr 26, 2023

We are targeting v15.1 for this change.

@ethan-sparkdevnetwork
Copy link
Contributor

Re-opening this issue as the fix is causing more issues and is being reverted in 15.2.

@JimMichael
Copy link
Collaborator

Does this closure mean the original workflow form bug won't be addressed after all?

@nairdo
Copy link
Member

nairdo commented Sep 13, 2023

Oops...too much GitHub automation (that was not really Josh's fault):
image

Ethan next time you might need to strip the "Fixes ####" part out from the revert commits so it stays open.

@JimMichael

Does this closure mean the original workflow form bug won't be addressed after all?

Yes, we're going to re-attack this particular issue from another angle (for v16.1) since the other solution caused more problems.

@nairdo nairdo reopened this Sep 13, 2023
ethan-sparkdevnetwork added a commit that referenced this issue Sep 22, 2023
…ction would not prevent a form from appearing. (fixes #5363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Topic: Workflows Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants