Transaction Matching Account Ordering Broken

[SteveSwaringen]

Please go through all the tasks below

• Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Financial accounts listed on the right side of the Transaction Matching page should be ordered accounting to the FinancialAccount.Order property in order to facilitate easily finding the most frequent accounts. This was the case in V13.V14 now renders these accounts in FinancialAccount.Id order, making it very difficult for accounting staff to reconcile batches.The way it was (and should be):

The way it is in V14 (and shouldn't be):

## Expected Behavior
Financial accounts listed on the right side of the Transaction Matching dialog should be ordered by FinancialAccount.Order.## Actual Behavior
Financial accounts listed on the right side of the Transaction Matching Dialog are ordered by FinancialAccount.Id.## Steps to Reproduce
Go to page/311. (May be different on your installation, but this seems to be a "core" page that is the same on most installations.)## Rock Version
V14.2## Client Culture Setting
en-US

[SteveSwaringen]

This issue was induced by modifications to the TransactionMatching.ascx.cs block that were part of this commit: https://github.com/lakepointe/Rock/commit/981f4d41777d043760559df07ef17c221be599d2#diff-08863471e16a228be6a6f00152141adfbbce797b21d1182ff318e82dd0ec2400

I don't pretend to understand why the changes in that commit broke the sort order (though I suspect it has something to do with not having an equivalent of the GetTree() call available on the FinancialAccountCache model). However, reverting those changes fixes the problem.

[SteveSwaringen]

Apologies for posting the link to the commit merged into our repository. This is the commit in the Spark repository: 981f4d4

[jonedmiston]

Fixed this in the commit above. @SteveSwaringen would love to know if this solved your issue before v16.1 goes to alpha (soon).