Personalized Communication History View Message Button Permissions Not working correctly

[JoshuaMaiorino]

Please go through all the tasks below

• Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

On the person history tab, the "View Message" button isn't showing in some cases even when the communication was created by the given user. Upon review of the code I uncovered a logic error by which permissions are checking the current person's Alias Id compared to the Created By Person Alias Id. This logic should be checking the person Id related to those aliases. Also, Some might contest it should also be checking the sender, because the sender should also have permission to see the Communication details.

Rock/RockWeb/Blocks/Communication/PersonalizedCommunicationHistory.ascx.cs

Line 1154 in 37e2ca9

|| ( CurrentPersonAliasId != null && info.CreatedByPersonAliasId != null && info.CreatedByPersonAliasId.Value == CurrentPersonAliasId.Value );

Expected Behavior

If the current user created or sent the communication in question, They should have permissions to see the detail, i.e. The 'View Message' button should render.

Actual Behavior

If the Person's Primary Alias differs from the alias that created the communication, or the person is the sender not the creator, the button doesn't render.

Steps to Reproduce

Have a communication created by person, perform a merge on that profile to the point where the primary alias changes.
Attempt to view the communication that was created via the Personalized Communication History Block.

Rock Version

14.2

Client Culture Setting

en-us