Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Block: Cannot Remove Default Text for Remote Authorization Prompt Message #5423

Closed
1 task done
mikedotmundy opened this issue Apr 27, 2023 · 2 comments
Closed
1 task done
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@mikedotmundy
Copy link

mikedotmundy commented Apr 27, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

In both the Login (Legacy) and Login Obsidian blocks, the field for Remote Authorization Prompt Message cannot be cleared out. The help text does say this field is optional, but upon clearing the text from it and saving the block settings, the original text "Log in with social account" reappears in the block.Screenshot 2023-04-27 at 07 57 12Screenshot 2023-04-27 at 07 55 58## Expected Behavior
Should be able to remove text from Remote Authorization Prompt Message field.## Actual Behavior
Cannot remove text from Remote Authorization Prompt Message field.## Steps to Reproduce

  • Go to Admin Tools > Security > Authentication Services
  • Enable Facebook (just enter some dummy settings)
  • Go to both the Login (Legacy) and the Login Obsidian blocks, enable Facebook as a Secondary Authentication Type, and remove text from Remote Authorization Prompt Message field.
  • Save
  • See that the default text "Log in with social account" reappears in the block.

Rock Version

en-US## Client Culture Setting
v14.2, v15.0, v16.0

@sparkdevnetwork-service sparkdevnetwork-service added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Apr 27, 2023
@BrentPirolli
Copy link

BrentPirolli commented Apr 27, 2023

Confirmed. If you use a space in the field, it strips that out as well and puts in the default text. If you use   however, it works to clear out the default text.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Feb 27, 2024
kylehenning added a commit that referenced this issue Mar 7, 2024
@nairdo
Copy link
Member

nairdo commented Mar 7, 2024

We're also going to include a data-migration in v16.4 that will add/set any existing block's to use the original default value Log in with social account but this change will now allow the Rock admin to clear out those block's default values.

@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants