Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone number not displaying - Transaction Entry V2 #5524

Closed
1 task done
TheArkChurch opened this issue Jul 20, 2023 · 2 comments
Closed
1 task done

Phone number not displaying - Transaction Entry V2 #5524

TheArkChurch opened this issue Jul 20, 2023 · 2 comments
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Finance Related to finance. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@TheArkChurch
Copy link
Collaborator

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Tell us what you see

When making a donation using the Giving V2 Block, when logged in, the persons phone number isn't displayed in the number box. This prompts the person to enter a number(already on their profile). Subsequently, Rock records this as a new phone number and disables SMS.

Screenshot 2023-07-20 at 12 42 53 AM Screenshot 2023-07-20 at 12 49 40 AM

Expected Behavior

Expected Behavior

If a person has a phone number, it should be populated. As an admin, I would also expect for the SMS to stay enabled, especially for reoccurring givers.

Actual Behavior

Actual Behavior

When a phone number is enter in a gift a new number is saved and the sms is set to false.

Steps to Reproduce

  • Make sure the person profile has a phone number with sms enabled.
  • Make a gift on a transaction entry v2 block, adding the same phone number in the profile
  • Check sms enabled in person history

Rock Version

14 and 15

Client Culture Setting

en-US

@otimoshc
Copy link

@TheArkChurch I can confirm that the phone number isn't being populated when a person has one on file. It looks like the pnbPhoneIndividual isn't being set here once the target person is populated.

I also confirmed the second issue with a small modification after looking at the code. The issue isn't with sms but with the block not checking the mobile phone attribute after checking the home phone attribute. Instead if a home phone number doesn't exist, it adds a new "Home Phone" duplicating the "Mobile Phone" as seen in your screenshot.

@TheArkChurch TheArkChurch added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Sep 18, 2023
@TheArkChurch
Copy link
Collaborator Author

For the home phone number duplication issue, it could be solved by

  1. Change instances of PERSON_PHONE_TYPE_HOME to PERSON_PHONE_TYPE_MOBILE
    or
  2. Add a Phone Type block setting to be used for this value when "Prompt for Phone" is set to Yes

I'm not sure which way would be the best way to handle this. We rarely use the home phone number type and would not use it in this block or for giving.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Sep 27, 2023
@sparkdevnetwork-service sparkdevnetwork-service changed the title Phone number not displaying - Transaction Entry V2 Phone number not displaying - Transaction Entry V2 Oct 17, 2023
@sparkdevnetwork-service sparkdevnetwork-service added the Type: Bug Confirmed bugs or reports that are very likely to be bugs. label Oct 17, 2023
shauncummings added a commit that referenced this issue Nov 2, 2023
…ction Entry V2 block to overwrite existing phone numbers. (Fixes #5524)
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Finance Related to finance. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

4 participants