Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder Type with Entity Type Connection Request Causing Exceptions #5550

Closed
1 task done
zackdutra opened this issue Aug 23, 2023 · 1 comment
Closed
1 task done
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Rock Internals Related to internal core stuff. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@zackdutra
Copy link

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When you create a new Reminder Type and set the Entity Type to Connection Request, and then add a new reminder using the Workflow Action, loading the /reminders page results in an ObjectDisposedException. This has been repeated and confirmed on the demo site.

Screen Shot 2023-08-22 at 5 31 59 PM
Screen Shot 2023-08-22 at 5 39 50 PM
Screen Shot 2023-08-22 at 5 39 44 PM
Screen Shot 2023-08-22 at 5 39 38 PM

Expected Behavior

Expected Behavior: The /reminders page loads and includes the newly created connection request reminder.

Actual Behavior

Actual Behavior: The /reminders page results in an ObjectDisposedException.

Steps to Reproduce

-Create a new Reminder Type for Connection Requests with the Entity Type set to Connection Request
Screen Shot 2023-08-22 at 5 36 00 PM

-Create a Workflow Trigger that triggers the above workflow.
Screen Shot 2023-08-22 at 5 36 30 PM

-Create a new connection request, connector set to yourself (or Alisha Admin if on Demo). Don't set follow up date yet. Save it.

-Edit the connection request and set the follow up date to today. (The above workflow will only trigger the add reminder step if a follow up date is set). Save it.

-Visit the reminders page.

Rock Version

15.1

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Rock Internals Related to internal core stuff. labels Aug 23, 2023
@nlBayside
Copy link
Contributor

I would also like to point out that we have had exceptions in the Process Reminders job occur since this problem. This appears to be a similar exception to #5552

Screen Shot 2023-08-25 at 8 33 15 AM

Here's the exception as text if that helps more than the screenshot.

at System.ThrowHelper.ThrowKeyNotFoundException()
at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Rock.Jobs.ProcessReminders.SendReminderCommunication(Person recipient, IQueryable`1 reminders, SystemCommunication notificationSystemCommunication, RockContext rockContext, Int32 remindersPerEntityType) in \Rock\Jobs\ProcessReminders.cs:line 451
at Rock.Jobs.ProcessReminders.ProcessCommunicationNotifications(SystemCommunication notificationSystemCommunication, IQueryable`1 activeReminders, RockContext rockContext) in \Rock\Jobs\ProcessReminders.cs:line 332
at Rock.Jobs.ProcessReminders.Execute() in \Rock\Jobs\ProcessReminders.cs:line 182
at Quartz.Core.JobRunShell.Run()

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Sep 11, 2023
shauncummings added a commit that referenced this issue Sep 21, 2023
…hed to entities that require lazy loading within the model logic. (Fixes #5550)
@chead4 chead4 removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Rock Internals Related to internal core stuff. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants